Created attachment 187787 [details] Patch This updates www/mod_auth_gssapi to version 1.6.0 released on 2017-11-05.
Not quite yet. 1.6.0 claims support for LibreSSL; I missed that at first. Updated patch will come once testing done.
Created attachment 187788 [details] Patch Updated patch; removes LibreSSL block.
Please: Confirm this change passes QA (portlint, poudriere in particular) Declare maintainer approval on attachments for ports you main by setting maintainer-approval flag to +. Attachment -> Details -> maintainer-approval [+]
Created attachment 187793 [details] Patch Updated patch yet again, to satisfy portlint about the order of USES and USE_*, as silly as that may be. Poudriere passes with DEFAULT_VERSIONS ssl=openssl, ssl=libressl, and ssl=libressl-devel, and the resulting module works correctly in Apache 2.4 with both openssl and libressl-devel.
Hi. Building fine in 12-CURRENT but not in 10 and 11 release. Error logs: http://poudriere.bs2.com.br/poudriere/data/103-amd64-pdbaio/2017-11-11_17h37m16s/logs/errors/ap24-mod_auth_gssapi-1.6.0.log http://poudriere.bs2.com.br/poudriere/data/103-i386-pdbaio/2017-11-11_17h41m39s/logs/errors/ap24-mod_auth_gssapi-1.6.0.log http://poudriere.bs2.com.br/poudriere/data/11-amd64-pdbaio/2017-11-11_18h57m41s/logs/errors/ap24-mod_auth_gssapi-1.6.0.log http://poudriere.bs2.com.br/poudriere/data/11-i386-pdbaio/2017-11-11_18h17m01s/logs/errors/ap24-mod_auth_gssapi-1.6.0.log Adding bison (USES= bison) dependency fixed that. http://poudriere.bs2.com.br/poudriere/data/latest-per-pkg/ap24-mod_auth_gssapi/1.6.0/ Could you verify? If it's ok for you, I'll proceed with this update.
Created attachment 187927 [details] Build log Hello, I cannot reproduce this on 11.1-STABLE. In particular, the missing "s" is where it belongs in every declaration of yyparse() throughout parser.c . The only thing I can think of is that byacc might have lost it through some bug of its own, and using bison instead avoided that. Could you try again with the original patch, and if it keeps failing, check whether the "s" is actually present in parser.y and missing in parser.c ?
(In reply to Christian Ullrich from comment #6) Sure, tests without bison: 10.3-RELEASE-p21 -> byacc - 1.9 20141006 ERROR 11.0-RELEASE-p12 -> byacc - 1.9 20160324 ERROR 12.0-CURRENT -> byacc - 1.9 20170430 OK ERROR /* compatibility with bison */ #ifdef YYPARSE_PARAM /* compatibility with FreeBSD */ # ifdef YYPARSE_PARAM_TYPE # define YYPARSE_DECL() yyparse(YYPARSE_PARAM_TYPE YYPARSE_PARAM) # else # define YYPARSE_DECL() yyparse(void *YYPARSE_PARAM) # endif #else # define YYPARSE_DECL() yyparse(const char **keys, const char **vals, int *statu) #endif OK /* compatibility with bison */ #ifdef YYPARSE_PARAM /* compatibility with FreeBSD */ # ifdef YYPARSE_PARAM_TYPE # define YYPARSE_DECL() yyparse(YYPARSE_PARAM_TYPE YYPARSE_PARAM) # else # define YYPARSE_DECL() yyparse(void *YYPARSE_PARAM) # endif #else # define YYPARSE_DECL() yyparse(const char **keys, const char **vals, int *status) #endif http://poudriere.bs2.com.br/parser.c http://poudriere.bs2.com.br/parser.y
Created attachment 187940 [details] Updated patch I do not have the faintest idea what is going on here ... I tested all version of byacc that have been released with everything since 10.0, and in isolation, none of them exhibits the bug. The binaries from the poudriere jails, on the other hand, do: - 10.4-RELEASE-p2 (-s http): Error - 10.4-STABLE (-s svn): Error - 11.0-RELEASE-p14 (-s http): Error - 11.1-RELEASE-p3 (-s http): OK 11-STABLE is OK, as seen yesterday. Rather than delve deeper into this thing, I came up with an, um, "creative" workaround; see new patch. With this patch, it works on all versions listed above. If I may, I will leave it up to you whether to commit this, or add the bison dependency instead.
A commit references this bug: Author: dbaio Date: Sun Nov 12 21:34:26 UTC 2017 New revision: 454085 URL: https://svnweb.freebsd.org/changeset/ports/454085 Log: www/mod_auth_gssapi: Update to 1.6.0 It was added support for LibreSSL upstream. While here, sort USES and add bison as build dependency because there is an issue when building with byacc < 20170201, more details in PR 223465. Changes: https://github.com/modauthgssapi/mod_auth_gssapi/releases/tag/v1.6.0 PR: 223465 Submitted by: Christian Ullrich <chris@chrullrich.net> (maintainer) Changes: head/www/mod_auth_gssapi/Makefile head/www/mod_auth_gssapi/distinfo
A commit references this bug: Author: dbaio Date: Sun Nov 12 21:36:47 UTC 2017 New revision: 51195 URL: https://svnweb.freebsd.org/changeset/doc/51195 Log: Add Christian Ullrich to contributors Maintainer of www/mod_auth_gssapi and www/multiwatch. PR: 223465 Changes: head/en_US.ISO8859-1/articles/contributors/contrib.additional.xml
Committed with bison dependency, thanks!