Bug 223514 - devel/py3-freezegun: Fix dependency to sqlite3
Summary: devel/py3-freezegun: Fix dependency to sqlite3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2017-11-08 09:54 UTC by Emanuel Haupt
Modified: 2017-11-26 02:09 UTC (History)
0 users

See Also:
koobs: maintainer-feedback+
koobs: merge-quarterly+

Attachments
Fix sqlite3 dependency (626 bytes, patch)
2017-11-08 09:54 UTC, Emanuel Haupt 		no flags Details | Diff
Updated patch using PYTHON_SUFFIX (936 bytes, patch)
2017-11-15 03:37 UTC, Emanuel Haupt 		koobs: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emanuel Haupt freebsd_committer freebsd_triage 2017-11-08 09:54:55 UTC 
Created attachment 187844 [details]
Fix sqlite3 dependency

The port lists databases/py3-sqlite3 as dependency which does not exist.

There are individual python-sub-version ports though:

# ls -ld /usr/ports/databases/py*sqlite3
drwxr-xr-x  3 root  wheel  5 Nov  3 17:22 /usr/ports/databases/py-sqlite3
drwxr-xr-x  2 root  wheel  3 Nov  3 17:22 /usr/ports/databases/py34-sqlite3
drwxr-xr-x  2 root  wheel  3 Nov  3 17:22 /usr/ports/databases/py35-sqlite3
drwxr-xr-x  2 root  wheel  3 Nov  3 17:22 /usr/ports/databases/py36-sqlite3
drwxr-xr-x  2 root  wheel  4 Nov  3 17:22 /usr/ports/databases/pypy-sqlite3

I suggest using PYTHON_PKGNAMEPREFIX to determine which port to be used.
Comment 1 Emanuel Haupt freebsd_committer freebsd_triage 2017-11-15 03:37:36 UTC 
Created attachment 188008 [details]
Updated patch using PYTHON_SUFFIX
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2017-11-15 03:55:44 UTC 
I won't be able to commit until Friday. If you can wait till then and would prefer me to commit, feel free to re-assign
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2017-11-15 03:56:09 UTC 
Comment on attachment 188008 [details]
Updated patch using PYTHON_SUFFIX

Approved by: koobs (maintainer )
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2017-11-15 03:56:36 UTC 
Fix also needs to be merged to quarterly
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-11-16 13:34:12 UTC 
A commit references this bug:

Author: ehaupt
Date: Thu Nov 16 13:33:36 UTC 2017
New revision: 454308
URL: https://svnweb.freebsd.org/changeset/ports/454308

Log:
  The port lists databases/py3-sqlite3 as dependency which does not exist. There
  are individual python-sub-version ports though (devel/py3{4,5,6}-sqlite3).

  Use PYTHON_SUFFIX to depend on requested version.

  PR:		223514
  Approved by:	koobs (maintainer)
  MFH:		2017Q4 (blanket)

Changes:
  head/devel/py-freezegun/Makefile
  head/devel/py3-freezegun/Makefile
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-11-16 13:40:19 UTC 
A commit references this bug:

Author: ehaupt
Date: Thu Nov 16 13:39:35 UTC 2017
New revision: 454309
URL: https://svnweb.freebsd.org/changeset/ports/454309

Log:
  MFH: r454308

  The port lists databases/py3-sqlite3 as dependency which does not exist. There
  are individual python-sub-version ports though (devel/py3{4,5,6}-sqlite3).

  Use PYTHON_SUFFIX to depend on requested version.

  PR:		223514
  Approved by:	koobs (maintainer)
  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2017Q4/
  branches/2017Q4/devel/py-freezegun/Makefile
  branches/2017Q4/devel/py3-freezegun/Makefile
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2017-11-26 02:09:59 UTC 
Committed and merged. Thanks Emanuel!