Bug 223655 - x11/xfce4-whiskermenu-plugin: Update to 1.7.4
Summary: x11/xfce4-whiskermenu-plugin: Update to 1.7.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-xfce (Nobody)
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2017-11-13 20:19 UTC by Olivier Duchateau
Modified: 2017-11-14 20:40 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+

Attachments
Patch to update x11/xfce4-whiskermenu-plugin (944 bytes, patch)
2017-11-13 20:19 UTC, Olivier Duchateau 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2017-11-13 20:19:42 UTC 
Created attachment 187976 [details]
Patch to update x11/xfce4-whiskermenu-plugin

Update to 1.7.4
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2017-11-13 20:23:05 UTC 
Thanks,

I am preparing and testing the same patch.

Will commit once I'm done with testing.
Comment 2 Olivier Duchateau 2017-11-13 21:06:18 UTC 
(In reply to Guido Falsi from comment #1)

In my 4.13 branch (for 2.1.4 release), I have also a patch [1], which fixes warnings (need to be reviewed by upstream).

[1] https://app.assembla.com/spaces/xfce4/subversion/source/HEAD/tags/4.13/x11/xfce4-whiskermenu-plugin/files/patch-panel-plugin_launcher.h
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2017-11-13 22:36:07 UTC 
(In reply to Olivier Duchateau from comment #2)
> (In reply to Guido Falsi from comment #1)
> 
> In my 4.13 branch (for 2.1.4 release), I have also a patch [1], which fixes
> warnings (need to be reviewed by upstream).
> 
> [1]
> https://app.assembla.com/spaces/xfce4/subversion/source/HEAD/tags/4.13/x11/
> xfce4-whiskermenu-plugin/files/patch-panel-plugin_launcher.h

As far as I can see that object is always used as a class and its definition too looks more like a class than a struct, so it looks correct to me.

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-11-14 20:40:24 UTC 
A commit references this bug:

Author: madpilot
Date: Tue Nov 14 20:40:16 UTC 2017
New revision: 454200
URL: https://svnweb.freebsd.org/changeset/ports/454200

Log:
  - Update xfce4-whiskermenu-plugin to 1.7.4
  - Add patch to fix some warnings.

  PR:		223655
  Submitted by:	Olivier Duchateau <duchateau.olivier@gmail.com>

Changes:
  head/x11/xfce4-whiskermenu-plugin/Makefile
  head/x11/xfce4-whiskermenu-plugin/distinfo
  head/x11/xfce4-whiskermenu-plugin/files/patch-panel-plugin_launcher.h