Bug 223718 - [maintainer] multimedia/syncplay update to 1.5.0
Summary: [maintainer] multimedia/syncplay update to 1.5.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-17 02:32 UTC by Christian Heckendorf
Modified: 2017-11-17 19:31 UTC (History)
1 user (show)

See Also:

Attachments
git diff from 1.4.0_1 to 1.5.0 (1.73 KB, patch)
2017-11-17 02:32 UTC, Christian Heckendorf 		no flags Details | Diff
diff from 1.4.0_1 with requested changes (2.08 KB, patch)
2017-11-17 15:43 UTC, Christian Heckendorf 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Heckendorf 2017-11-17 02:32:13 UTC 
Created attachment 188064 [details]
git diff from 1.4.0_1 to 1.5.0

Update to 1.5.0.

git diff attached.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2017-11-17 06:39:13 UTC 
Hi there

1) You should not need to use
INSTALLS_ICONS= yes
as this is not a Gtk+ port.

2) python:2 should probably be python:2.7
   [python:2 = give me the python2 meta port, python:2.7 = I need to have python2.7]

3) USES should appear above USE_GITHUB


mfg Tobias
Comment 2 Christian Heckendorf 2017-11-17 15:43:42 UTC 
Created attachment 188076 [details]
diff from 1.4.0_1 with requested changes

Hi Tobias,
Thanks for the suggestions, they appear to be correct. Here's a new diff with the changes included.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-11-17 19:31:14 UTC 
A commit references this bug:

Author: tcberner
Date: Fri Nov 17 19:30:13 UTC 2017
New revision: 454381
URL: https://svnweb.freebsd.org/changeset/ports/454381

Log:
  Update multimedia/syncplay to 1.5.0

  PR:		223718
  Submitted by:	Christian Heckendorf <heckendorfc@gmail.com> (maintainer)

Changes:
  head/multimedia/syncplay/Makefile
  head/multimedia/syncplay/distinfo
  head/multimedia/syncplay/pkg-plist
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2017-11-17 19:31:32 UTC 
Committed. Thanks :)