Created attachment 188194 [details] [patch] fix a couple more hard-coded /usr/local references fix hard-coded /usr/local in owrep.c (config file). Otherwise it will look for the config file in /usr/local even if LOCALBASE is not /usr/local or PREFIX is not /usr/local. less important (since CFLAGS is overridden by ports build) - fix hard-coded -I/usr/local/include in Makefile. This just fixed another case of /usr/local I noticed. But we override CFLAGS in MAKE_ARGS, so this part of the patch is just to have the Makefile look clean of hard-coded /usr/local references.
These are fine. Will fix upstream in due course.
Thanks, Bob. By the way, the URL in pkg-descr has no mention of owrep, by the way. It might be good to add something to that web page for owrep. Also there is a core dump if one enters an invalid location for -l - this is a separate bug. Here's a patch for that (note: original has tabs, but this inline patch should point out the problem): --- owrep.c.orig 2017-05-30 23:47:32.000000000 +0000 +++ owrep.c 2017-11-22 23:19:20.819220000 +0000 @@ -186,7 +186,7 @@ /* Check for mandatory settings */ if(config.location == 0) { - error(0, + error( "there is no LOCATION entry in the " "configuration file, and no -l option" " is present");
Fixes now incorporated - thanks. Apologies for long delay. PR 226535 references.
A commit references this bug: Author: tobik Date: Sun Mar 11 19:33:01 UTC 2018 New revision: 464195 URL: https://svnweb.freebsd.org/changeset/ports/464195 Log: misc/owrep: Update to 1.2 - Make PREFIX-safe PR: 223801, 226535 Submitted by: bob@eager.cx (maintainer) Changes: head/misc/owrep/Makefile head/misc/owrep/distinfo head/misc/owrep/files/patch-Makefile head/misc/owrep/pkg-descr head/misc/owrep/pkg-plist
Fixed via ports r464195