Bug 223815 - databases/arangodb32: Fix i386 and FreeBSD 10 builds
Summary: databases/arangodb32: Fix i386 and FreeBSD 10 builds
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nikolai Lifanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-23 11:20 UTC by dev
Modified: 2017-12-01 16:30 UTC (History)
1 user (show)

See Also:


Attachments
i386 and FreeBSD 10 build fix (5.60 KB, patch)
2017-11-23 11:20 UTC, dev
no flags Details | Diff
Cleaned up patch (1.76 KB, patch)
2017-11-28 14:26 UTC, dev
no flags Details | Diff
build failure on 10.4-RELEASE i386 (34.62 KB, application/x-xz)
2017-11-28 15:29 UTC, Nikolai Lifanov
no flags Details
i386 build fix (6.51 KB, patch)
2017-11-28 16:02 UTC, dev
no flags Details | Diff
build failure on 10.4-RELEASE i386 (35.25 KB, application/x-xz)
2017-11-28 18:03 UTC, Nikolai Lifanov
no flags Details
Restrict the build to amd64 (6.51 KB, patch)
2017-11-28 20:22 UTC, dev
no flags Details | Diff
Really restrict the build to amd64 (5.02 KB, patch)
2017-11-28 20:24 UTC, dev
no flags Details | Diff
Clean patch (1.30 KB, patch)
2017-11-28 20:26 UTC, dev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dev 2017-11-23 11:20:13 UTC
Created attachment 188212 [details]
i386 and FreeBSD 10 build fix

This patch removes the hardcoded x64 gyp build paths and replaces them with architecture specific ones.

It also mandates clang 4.0 on FreeBSD 10.
Comment 1 Nikolai Lifanov freebsd_committer freebsd_triage 2017-11-28 14:23:56 UTC
I'm testing builds with latest diff in Phabricator right now.
Comment 2 dev 2017-11-28 14:26:53 UTC
Created attachment 188357 [details]
Cleaned up patch
Comment 3 dev 2017-11-28 14:27:15 UTC
(In reply to Nikolai Lifanov from comment #1)
Thank you! I've just uploaded a reviewed patch.
Comment 4 Nikolai Lifanov freebsd_committer freebsd_triage 2017-11-28 15:29:51 UTC
Created attachment 188359 [details]
build failure on 10.4-RELEASE i386

This still doesn't build for me.
Please see the attached log.
Comment 5 dev 2017-11-28 15:50:29 UTC
(In reply to Nikolai Lifanov from comment #4)
Does the build only fail on i386? That might require us to ONLY_FOR_ARCHS it to amd64.
Comment 6 dev 2017-11-28 16:02:50 UTC
Created attachment 188360 [details]
i386 build fix

Could you please try this one a spin? Thanks.
Comment 7 Nikolai Lifanov freebsd_committer freebsd_triage 2017-11-28 17:44:06 UTC
Can you take out the patches you are not changing from the diff?
I'm going to do this manually and retest.
Comment 8 Nikolai Lifanov freebsd_committer freebsd_triage 2017-11-28 18:02:07 UTC
When you initially submitted the port, you listed galu@packetdam.com as the MAINTAINER. I'll need to add a maintainer to "Approved by:" line when committing the change and it's easy to do when Bugzilla email address matches the MAINTAINER address. This is you, right?
Comment 9 Nikolai Lifanov freebsd_committer freebsd_triage 2017-11-28 18:03:51 UTC
Created attachment 188363 [details]
build failure on 10.4-RELEASE i386

The latest patch still fails for me.
Please see the updated build log.
Comment 10 dev 2017-11-28 19:47:42 UTC
(In reply to Nikolai Lifanov from comment #8)
Yes, that's me, thanks.
Comment 11 Nikolai Lifanov freebsd_committer freebsd_triage 2017-11-28 19:52:20 UTC
OK, awesome! But the last patch still doesn't build for me.
I attached the last build log.
Comment 12 dev 2017-11-28 20:22:48 UTC
Created attachment 188366 [details]
Restrict the build to amd64
Comment 13 dev 2017-11-28 20:23:44 UTC
(In reply to Nikolai Lifanov from comment #11)

On it, thanks for bearing with me. Could you please try the latest patch? I've tried a build in a 32bit jail but there is quite some amount of work to get it to build cleanly.
Comment 14 dev 2017-11-28 20:24:53 UTC
Created attachment 188367 [details]
Really restrict the build to amd64
Comment 15 dev 2017-11-28 20:26:18 UTC
Created attachment 188368 [details]
Clean patch
Comment 16 dev 2017-11-30 19:45:41 UTC
Hi Nikolai, would you mind giving the latest patch a try? I think that should fix the failing builds. Thanks!
Comment 17 Nikolai Lifanov freebsd_committer freebsd_triage 2017-11-30 21:06:40 UTC
Hi! I'm already trying it. I'm waiting for the builds to finish.
Comment 18 commit-hook freebsd_committer freebsd_triage 2017-12-01 16:29:58 UTC
A commit references this bug:

Author: lifanov
Date: Fri Dec  1 16:29:36 UTC 2017
New revision: 455300
URL: https://svnweb.freebsd.org/changeset/ports/455300

Log:
  fix databases/arangodb32 on FreeBSD 10.x

  o Fix build on FreeBSD 10.x by requiring recent LLVM
  o Only build on amd64 - many hardcoded directories

  PR:		223815
  Submitted by:	galu@packetdam.com (maintainer, same as dev@dudu.ro)
  Differential Revision:	https://reviews.freebsd.org/D13282

Changes:
  head/databases/arangodb32/Makefile
Comment 19 Nikolai Lifanov freebsd_committer freebsd_triage 2017-12-01 16:30:20 UTC
Committed, thanks!