Created attachment 188503 [details] patch Hi Alexey, I am attaching the suggested patch. It builds, but it still has unstripped executables warnings, and a bad symbolic link warning. Could you please bring it to completion and commit? I would like to proceed with science/ospray, but it wants the newer version of embree. Thank you! Yuri
Created attachment 188505 [details] patch
Hi Yuri, Thanks for the patch. I remember now why I was dragging my feet with Embree update: you wanted to have ISPC support, and wanted it to be enabled by default. I was a bit reluctant towards this because of heavy Clang/LLVM dependencies, and because ISPC wanted version 3.8 while our X.org/Mesa stack is using 4.0. I didn't like the idea of having both versions installed, but when I tried to build ISPC (which was at version 1.9.1 at that time) against version 4.0, it failed (I cannot recall exact details now). Today, I've noticed that ISPC was updated to version 1.9.2 last month, and tried to build it against Clang 4.0 again. It worked! I guess if we can make it default version I can come to peace with enabling Embree support for ISPC out of the box. Can you confirm that 4.0 is OK and make the switch if it is?
(In reply to Alexey Dokuchaev from comment #2) Hi Alexey, Sorry for the delay with response. The ISPC update for clang-50 is in review. Once it's approved and I commit it, please update embree, if this doesn't break anything. Regards, Yuri
A commit references this bug: Author: danfe Date: Fri Dec 29 16:46:47 UTC 2017 New revision: 457515 URL: https://svnweb.freebsd.org/changeset/ports/457515 Log: - Belatedly update `graphics/embree' to the latest version, 2.17.1 - Add ISPC option and enable it by default (this pulls rather heavy `devel/llvm50' via BUILD_DEPENDS and normally would not be enabled by default, but since Embree is most likely to be used in graphics applications, it is safe to assume that users already have LLVM 5 installed because X.org/Mesa stack unconditionally requires it) - OpenEXR support was removed upstream since version 2.13.0 back in November 11, 2016: https://github.com/embree/embree/commit/483491e (as usual, unfortunately, no explanation was provided in the log) - Remove CXXFLAGS+=-msse2 required for i386 earlier, not needed now - Add missing USE_GL, USE_XORG components as prompted by `stage-qa' PR: 214577, 224066 Because GitHub releases (tarballs) are not fetched with correct modification time, set TIMESTAMP to 1510648523 which corresponds to commit 90e49f2 tagged as this release. Changes: head/graphics/embree/Makefile head/graphics/embree/distinfo head/graphics/embree/pkg-descr head/graphics/embree/pkg-plist
Port was updated as of ports r457515, thank you.