Bug 224190 - lang/php72 missing shared library libargon2.so
Summary: lang/php72 missing shared library libargon2.so
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Torsten Zuehlsdorff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-08 21:20 UTC by Jack
Modified: 2018-01-15 11:04 UTC (History)
3 users (show)

See Also:


Attachments
patch to add pkg-config file and SONAME to libargon2 (1.87 KB, patch)
2017-12-11 02:24 UTC, Christopher Hall
hsw: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2017-12-08 21:20:49 UTC
When I run pkg check -d
with php72 and mod_php72 installed, it displays missing shared library of libargon2.so even though it's installed.

Checking all packages: 100%
mod_php72 is missing a required shared library: libargon2.so
php72 is missing a required shared library: libargon2.so
Comment 1 Samee Shahzada 2017-12-09 19:10:28 UTC
yep. I'm also having this issue. Tried reinstalling php72, libargon2, pkg, rebuilding he pkg database. But issue remains.
Comment 2 Christopher Hall 2017-12-11 02:24:01 UTC
Created attachment 188700 [details]
patch to add pkg-config file and SONAME to libargon2

This patches everything for bug #222344 and inaddition adds the SONAME and symlink
Comment 3 Christopher Hall 2017-12-11 04:13:11 UTC
I built the libargon2 on 11.1 AMD64 (poudriere porttest ok)

the pkg info libargon2 now adds the lines:

  Shared Libs provided:
	libargon2.so.0

Also:
  # readelf -d /usr/local/lib/libargon2.so |grep SONAME                                                         
  0x000000000000000e SONAME               Library soname: [libargon2.so.0]


so the above patch should work
Comment 4 Oliver Schonrock 2017-12-11 08:45:16 UTC
patch works for me:

# cd /usr/ports/security/libargon2/
# make deinstall clean
# wget -qO-
'https://bz-attachments.freebsd.org/attachment.cgi?id=188700&action=diff&format=raw&headers=1'
| patch -p3

# cd /usr/ports/lang/php72
# make deinstall clean install

# # builds both php72 and libargon

# pkg check --dependencies
Checking all packages: 100%

# php -r 'echo password_hash("password", PASSWORD_ARGON2I). "\n";'
$argon2i$v=19$m=1024,t=2,p=2$Vm1uSkpXLldNZnBxZWhxeQ$qGk/xMWUTuOz9yGFXFPCJi4HK5vexbFkQ14msvEYcPY

Good to commit?

Thanks
Comment 5 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-12-11 13:49:17 UTC
Looks fine to me and passes all my build-tests! :)

Before committing i need a formal approval of Christopher for his patch. Next to the patch in the attachment list is "Details". On the following site there is a section "Flags". Please set maintainer-approval to "+". Its hard to find :D

Otherwise just wrote it into the comments please.

Greetings,
Torsten
Comment 6 Oliver Schonrock 2017-12-11 14:37:15 UTC
@Christopher 

obviously the paths in the patch need changing, if you want to put it into 

/usr/ports/security/libargon2/files

(hence my patch -p3)

ports/security/libargon2/ 

needs stripping off the front of the path lines in the patch

or were you planning just to commit the new versions of Makefile and pkg-plist to svn.ports?
Comment 7 Christopher Hall 2017-12-12 01:04:19 UTC
Comment on attachment 188700 [details]
patch to add pkg-config file and SONAME to libargon2

added maintainer approval
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-12-12 11:39:24 UTC
A commit references this bug:

Author: tz
Date: Tue Dec 12 11:38:49 UTC 2017
New revision: 456119
URL: https://svnweb.freebsd.org/changeset/ports/456119

Log:
  security/libargon2: Add SONAME to shared library

  Also add pkg-config file

  PR:           224190 222344
  Submitted by: Christopher Hall (maintainer)
  Reported by:  xxjack12xx@gmail.com
  Approved by:  maintainer

Changes:
  head/security/libargon2/Makefile
  head/security/libargon2/pkg-plist
Comment 9 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-12-12 11:39:54 UTC
Committed, thanks! :)
Comment 10 Jack 2017-12-12 20:28:34 UTC
Should all the ports that depend on libargon2 have their PORTREVISION bumped so they can be rebuilt with the new library changes?
Comment 11 Jack 2017-12-12 20:28:54 UTC
reopen
Comment 12 Christopher Hall 2017-12-13 01:04:35 UTC
(In reply to xxjack12xx from comment #10)
Shoukld not be necessary as poudriere will rebuild any ports that that have libargon2 as a dependency and pkg should recognise this an upgrade the ports.
Comment 13 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-12-13 16:57:11 UTC
(In reply to Christopher Hall from comment #12)

> Shoukld not be necessary as poudriere will rebuild any ports that that have 
> libargon2 as a dependency and pkg should recognise this an upgrade the ports.

That is wrong. It is needed. There are scenarios for local usage of the ports-tree and of course portmaster or portupgrade needs the bumps to determine the update. 

Also its required by the porters handbook and i clearly forgot this. :/ Thanks for the reminder. I will bump this tomorrow!
Comment 14 Christopher Hall 2017-12-14 00:45:23 UTC
Thanks for the correction Torsten, I'll need to keep that in mind fo my own local ports
Comment 15 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2018-01-15 11:04:02 UTC
Sorry i didn't bump in time - was hit by live. 

Meanwhile libargon was updated in 458583 to 20171227. Therefore there is no longer a need to bump and i will close the PR without any further action.