Created attachment 188752 [details] svn diff This is an svn diff for Yoshimi 1.5.5
Fix Summary. I would notify maintainer except bugzilla won't let me.
(In reply to Mark Linimon from comment #1) it's a bit complicated at the moment but my current bugzilla email address is owen94012@gmail.com, I am migrating my emails from gmail to private servers.
Submitter is maintainer from another address.
I'm going to take this bug, but I consider it rude to be pinged like you did on bug #223397 while also sending an email to ports@. Please do not do this.
(In reply to Tobias Kortkamp from comment #4) My apologizes Tobias, I wasn't sure what's the proper procedure. Won't happen again.
A commit references this bug: Author: tobik Date: Tue Dec 12 15:15:08 UTC 2017 New revision: 456167 URL: https://svnweb.freebsd.org/changeset/ports/456167 Log: audio/yoshimi: Update to 1.5.5 PR: 224274 Submitted by: maintainer Changes: head/audio/yoshimi/Makefile head/audio/yoshimi/distinfo head/audio/yoshimi/pkg-plist
Committed, thanks! The patch you attached here didn't delete any patch files. Not sure how you generated it. If you delete files make sure to use `svn rm` instead of just `rm`, so that svn knows you want to delete it. But files/patch-src_CMakeLists.txt needs to stay anyway to fix the build on FreeBSD 10.3 (see the top of the patch as to why) and to install man pages into the correct location. If you want to get rid of it in the future consider sending it to upstream.
(In reply to Tobias Kortkamp from comment #7) Thanks for the tips, I am working with the guys upstream. I built it with poudriere but I was unsure how to get SVN diff to work in there so I just overwrote the files in a manually created jail then did a svn diff of that. I'm not sure how to do an svn diff from poudriere after a testport command but that's a different thing.