Bug 224422 - Switch databases/soci to <opt>_CMAKE_BOOL
Summary: Switch databases/soci to <opt>_CMAKE_BOOL
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Julien Laffaye
URL: https://reviews.freebsd.org/D12957
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-18 09:26 UTC by Adriaan de Groot
Modified: 2018-01-04 12:48 UTC (History)
1 user (show)

See Also:
jlaffaye: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adriaan de Groot freebsd_committer freebsd_triage 2017-12-18 09:26:49 UTC 
Options which translate to CMake arguments -D<content>:BOOL=<ON|OFF>
can be simplified through the use of <opt>_CMAKE_BOOL.

This is basically cleanup, using newer features of USES=cmake; it was spotted while fixing soci for the CMake 3.9 update. It's been languishing in Phabricator for a while.
Comment 1 Julien Laffaye freebsd_committer freebsd_triage 2018-01-04 07:56:23 UTC 
LGTM
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-01-04 12:47:36 UTC 
A commit references this bug:

Author: adridg
Date: Thu Jan  4 12:46:36 UTC 2018
New revision: 458025
URL: https://svnweb.freebsd.org/changeset/ports/458025

Log:
  Switch databases/soci to <opt>_CMAKE_BOOL.

  This simplifies the Makefile somewhat -- it is only a cosmetic change.
  While here, massage COMMENT to satisfy portlint.

  PR:		224422
  Reviewed by:	jlaffaye (maintainer)
  Approved by:	rakuco (mentor)
  Differential Revision:	https://reviews.freebsd.org/D12957

Changes:
  head/databases/soci/Makefile