Bug 224435 - print/hplip-plugin: broken in both quarterly and head
Summary: print/hplip-plugin: broken in both quarterly and head
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ben Woods
URL:
Keywords:
: 224408 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-12-18 20:56 UTC by Mason Loring Bliss
Modified: 2017-12-19 05:53 UTC (History)
5 users (show)

See Also:
woodsb02: merge-quarterly-


Attachments
Makefile patch - new source (429 bytes, patch)
2017-12-18 20:57 UTC, Mason Loring Bliss
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mason Loring Bliss freebsd_triage 2017-12-18 20:56:37 UTC
The upstream source for hplip-plugin is broken. The attached patch fixes things.

Thanks to slackbuilds.org for inspiration for an alternate source.
Comment 1 Mason Loring Bliss freebsd_triage 2017-12-18 20:57:35 UTC
Created attachment 188941 [details]
Makefile patch - new source

Makefile patch - new source
Comment 2 Brad Davis freebsd_committer freebsd_triage 2017-12-18 21:18:23 UTC
Over to maintainer
Comment 3 Ben Woods freebsd_committer freebsd_triage 2017-12-18 21:21:45 UTC
*** Bug 224408 has been marked as a duplicate of this bug. ***
Comment 4 John Baldwin freebsd_committer freebsd_triage 2017-12-18 23:28:36 UTC
Confirmed the new MASTER_SITE works for me.
Comment 5 Ben Woods freebsd_committer freebsd_triage 2017-12-19 05:42:22 UTC
I agree with this new value for MASTER_SITES.

Within the print/hplip file ${WRKSRC}/installer/pluginhandler.py, the download location for the plugin is revealed:

The function __getPluginInformation downloads information about the available plugins from http://hplip.sf.net/plugin.conf.

This file clearly shows the official URL for downloading the plugin is:
http://www.openprinting.org/download/printdriver/auxfiles/HP/plugins/hplip-%%PORTVERSION%%-plugin.run
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-12-19 05:48:07 UTC
A commit references this bug:

Author: woodsb02
Date: Tue Dec 19 05:47:40 UTC 2017
New revision: 456706
URL: https://svnweb.freebsd.org/changeset/ports/456706

Log:
  print/hplip and print/hplip-plugin: Fix URL and LICENSE information.

  The URL change reflects a recent website change by HP, and was
  preventing print/hplip-plugin from fetching correctly.

  The LICENSE change reflects the fact that the introductory license
  to the python source files mention that a later version of the GPL
  can optionally be used.

  PR:		224435
  PR:		224408
  Submitted by:	Mason Loring Bliss <mason@blisses.org>
  Reported by:	jhb
  Reviewed by:	jhb
  MFH:		2017Q4

Changes:
  head/print/hplip/Makefile
  head/print/hplip/pkg-descr
  head/print/hplip-plugin/Makefile
  head/print/hplip-plugin/pkg-descr
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-12-19 05:53:16 UTC
A commit references this bug:

Author: woodsb02
Date: Tue Dec 19 05:52:38 UTC 2017
New revision: 456707
URL: https://svnweb.freebsd.org/changeset/ports/456707

Log:
  MFH: r456706

  print/hplip and print/hplip-plugin: Fix URL and LICENSE information.

  The URL change reflects a recent website change by HP, and was
  preventing print/hplip-plugin from fetching correctly.

  The LICENSE change reflects the fact that the introductory license
  to the python source files mention that a later version of the GPL
  can optionally be used.

  PR:		224435
  PR:		224408
  Submitted by:	Mason Loring Bliss <mason@blisses.org>
  Reported by:	jhb
  Reviewed by:	jhb

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2017Q4/
  branches/2017Q4/print/hplip/Makefile
  branches/2017Q4/print/hplip/pkg-descr
  branches/2017Q4/print/hplip-plugin/Makefile
  branches/2017Q4/print/hplip-plugin/pkg-descr
Comment 8 Ben Woods freebsd_committer freebsd_triage 2017-12-19 05:53:53 UTC
Committed - thanks!