Bug 224794 - mail/metamail: Fix build when X11 option is enabled
Summary: mail/metamail: Fix build when X11 option is enabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-31 15:17 UTC by Ting-Wei Lan
Modified: 2018-01-01 09:10 UTC (History)
1 user (show)

See Also:

Attachments
Patch for building metamail with X11 option enabled (2.21 KB, patch)
2017-12-31 15:17 UTC, Ting-Wei Lan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2017-12-31 15:17:59 UTC 
Created attachment 189290 [details]
Patch for building metamail with X11 option enabled

It has been broken for more than one year. r412348 is the last version I can build successfully.

===>  Building package for metamail-2.7_14
pkg-static: Unable to access file /wrkdirs/usr/ports/mail/metamail/work/stage/usr/local/bin/mailto-hebrew:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/mail/metamail/work/stage/usr/local/bin/shownonascii:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/mail/metamail/work/stage/usr/local/lib/metamail/fonts/heb6x13.pcf:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/mail/metamail/work/stage/usr/local/lib/metamail/fonts/heb8x13.pcf:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/mail/metamail/work/stage/usr/local/lib/metamail/fonts/heb8x13B.pcf:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/mail/metamail/work/stage/usr/local/lib/metamail/fonts/fonts.dir:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/mail/metamail/work/stage/usr/local/lib/metamail/fonts/fonts.alias:No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/ports/mail/metamail

The problem is that later commits remove patches required to install fonts and add patches to ignore mailto-hebrew and shownonascii. To fix the problem, I moved the original patch-Makefile to X11_EXTRA_PATCHES_OFF and made a new patch based on patch-Makefile for X11_EXTRA_PATCHES.

Since I could not find a way to generate a svn patch that could be applied easily when there are renamed or copied files, applying the patch I attached here requires running 'svn mv' and 'svn cp' commands first.

Steps to apply the patch:

 1. svn cp files/patch-Makefile files/extra-patch-Makefile-x11
 2. svn mv files/patch-Makefile files/extra-patch-Makefile-nox11
 3. svn patch metamail.patch
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-01-01 09:10:01 UTC 
A commit references this bug:

Author: pi
Date: Mon Jan  1 09:09:52 UTC 2018
New revision: 457758
URL: https://svnweb.freebsd.org/changeset/ports/457758

Log:
  mail/metamail: fix build with X11 option enabled

  - It has been broken for more than one year. r412348 was the last
    buildable version

  PR:		224794
  Submitted by:	Ting-Wei Lan <lantw44@gmail.com>

Changes:
  head/mail/metamail/Makefile
  head/mail/metamail/files/extra-patch-Makefile-nox11
  head/mail/metamail/files/extra-patch-Makefile-x11
  head/mail/metamail/files/patch-Makefile
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2018-01-01 09:10:59 UTC 
Testbuilds are fine, committed, thanks!