Bug 224805 - net/ceph: don't force LLD
Summary: net/ceph: don't force LLD
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-01-01 01:47 UTC by Jan Beich
Modified: 2018-03-11 16:01 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (wjw)
jbeich: merge-quarterly?


Attachments
v0 (634 bytes, patch)
2018-01-01 01:47 UTC, Jan Beich
jbeich: maintainer-approval? (wjw)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2018-01-01 01:47:19 UTC
Created attachment 189301 [details]
v0

As discussed in review D13699 ceph-12.2.2 builds fine even with ld.bfd (default). Can you confirm on your end, including tests? Probably, low priority until the next port update.

Build logs:
11.1 amd64 + ceph 12.2.2 + boost 1.65.1_1 - https://ptpb.pw/3UMG
12.0 amd64 + ceph 12.2.2 + boost 1.65.1_1 - https://ptpb.pw/iFtc
11.1 amd64 + ceph 12.2.2 + boost 1.66.0   - https://ptpb.pw/xY_H
12.0 amd64 + ceph 12.2.2 + boost 1.66.0   - https://ptpb.pw/2yix
Comment 1 Willem Jan Withagen 2018-02-25 22:06:26 UTC
(In reply to Jan Beich from comment #0)
Yup, it is on my list of amends, as is USE_LDAP instead of hard wiring openldap.
Probably also need to add some portscout RE to supress detection of 13.X as a better version.

This week Ceph 12.2.3 was released. So I'll be building another version "real soon"
Comment 2 Willem Jan Withagen 2018-02-28 10:35:43 UTC
(In reply to Willem Jan Withagen from comment #1)
(In reply to Jan Beich from comment #0)

Found another linking issue which I could resolve with ld.lld.
So I think I want to retain this option for the time being.

[100%] Linking CXX executable ../../bin/unittest_log
CMakeFiles/unittest_log.dir/__/log/test.cc.o: file not recognized: File format not recognized
c++: error: linker command failed with exit code 1 (use -v to see invocation)
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-03-06 01:00:20 UTC
A commit references this bug:

Author: jbeich
Date: Tue Mar  6 00:59:23 UTC 2018
New revision: 463680
URL: https://svnweb.freebsd.org/changeset/ports/463680

Log:
  net/ceph: update to 12.2.4

  - Convert to USE_OPENLDAP
  - Drop LLD dependency [1]
  - Limit portscout reports to 12.*

  Changes:	https://ceph.com/releases/v12-2-3-luminous-released/
  Changes:	https://ceph.com/releases/v12-2-4-luminous-released/
  PR:		224805 [1] 226376
  Submitted by:	Willem Jan Withagen (maintainer)

Changes:
  head/net/ceph/Makefile
  head/net/ceph/distinfo
  head/net/ceph/files/file-git_version
  head/net/ceph/files/patch-src_common_bounded__key__counter.h
  head/net/ceph/files/patch-src_tools_ceph__kvstore__tool.cc
  head/net/ceph/pkg-plist
Comment 4 Walter Schwarzenfeld freebsd_triage 2018-03-11 16:01:21 UTC
Fixed in ports r463680.