Bug 224854 - ports-mgmt/fastest_sites: Fix broken runtime with newer bsd.sites.mk
Summary: ports-mgmt/fastest_sites: Fix broken runtime with newer bsd.sites.mk
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wesley Shields
URL: https://forums.freebsd.org/threads/63...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-01-03 06:28 UTC by Tobias Kortkamp
Modified: 2018-01-17 14:31 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (wxs)

Attachments
fastest_sites.diff (1.13 KB, patch)
2018-01-03 06:28 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (wxs)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2018-01-03 06:28:14 UTC 
Created attachment 189356 [details]
fastest_sites.diff

fastest_sites can't parse entries like

https://archives.fedoraproject.org/pub/archive/fedora/linux/%SUBDIR%/:DEFAULT,SOURCE

 => Checking servers for MASTER_SITE_FEDORA_LINUX (6 servers)
Traceback (most recent call last):
  File "/usr/local/bin/fastest_sites", line 164, in <module>
    latency_list = FindFastest(varname, sitelist)
  File "/usr/local/bin/fastest_sites", line 110, in FindFastest
    AsyncConnect(url, callback)
  File "/usr/local/bin/fastest_sites", line 53, in __init__
    self.ParseURL()
  File "/usr/local/bin/fastest_sites", line 64, in ParseURL
    (scheme, remainder) = self._url.split(":", 2)
ValueError: too many values to unpack

Applying the attached patch fixes this.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-01-17 14:30:25 UTC 
A commit references this bug:

Author: tobik
Date: Wed Jan 17 14:29:16 UTC 2018
New revision: 459259
URL: https://svnweb.freebsd.org/changeset/ports/459259

Log:
  ports-mgmt/fastest_sites: Fix runtime with modern bsd.sites.mk

  fastest_sites currently can't parse entries like

  https://archives.fedoraproject.org/pub/archive/fedora/linux/%SUBDIR%/:DEFAULT,SOURCE

   => Checking servers for MASTER_SITE_FEDORA_LINUX (6 servers)
  Traceback (most recent call last):
    File "/usr/local/bin/fastest_sites", line 164, in <module>
      latency_list = FindFastest(varname, sitelist)
    File "/usr/local/bin/fastest_sites", line 110, in FindFastest
      AsyncConnect(url, callback)
    File "/usr/local/bin/fastest_sites", line 53, in __init__
      self.ParseURL()
    File "/usr/local/bin/fastest_sites", line 64, in ParseURL
      (scheme, remainder) = self._url.split(":", 2)
  ValueError: too many values to unpack

  PR:		224854

Changes:
  head/ports-mgmt/fastest_sites/Makefile
  head/ports-mgmt/fastest_sites/files/
  head/ports-mgmt/fastest_sites/files/patch-fastest__sites-20110317.py
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-01-17 14:31:28 UTC 
A commit references this bug:

Author: tobik
Date: Wed Jan 17 14:30:52 UTC 2018
New revision: 459260
URL: https://svnweb.freebsd.org/changeset/ports/459260

Log:
  MFH: r459259

  ports-mgmt/fastest_sites: Fix runtime with modern bsd.sites.mk

  fastest_sites currently can't parse entries like

  https://archives.fedoraproject.org/pub/archive/fedora/linux/%SUBDIR%/:DEFAULT,SOURCE

   => Checking servers for MASTER_SITE_FEDORA_LINUX (6 servers)
  Traceback (most recent call last):
    File "/usr/local/bin/fastest_sites", line 164, in <module>
      latency_list = FindFastest(varname, sitelist)
    File "/usr/local/bin/fastest_sites", line 110, in FindFastest
      AsyncConnect(url, callback)
    File "/usr/local/bin/fastest_sites", line 53, in __init__
      self.ParseURL()
    File "/usr/local/bin/fastest_sites", line 64, in ParseURL
      (scheme, remainder) = self._url.split(":", 2)
  ValueError: too many values to unpack

  PR:		224854

  Approved by:	ports-secteam blanket

Changes:
_U  branches/2018Q1/
  branches/2018Q1/ports-mgmt/fastest_sites/Makefile
  branches/2018Q1/ports-mgmt/fastest_sites/files/