Bug 224858 - [MAINTAINER-UPDATE] dns/knot2: update to 2.6.4
Summary: [MAINTAINER-UPDATE] dns/knot2: update to 2.6.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2018-01-03 09:20 UTC by Leo Vandewoestijne
Modified: 2018-02-04 14:00 UTC (History)
2 users (show)

See Also:
riggs: merge-quarterly+


Attachments
knot 2.6.4 (1.12 KB, text/plain)
2018-01-03 09:20 UTC, Leo Vandewoestijne
no flags Details
update knot2 + patch atomic i386 (3.57 KB, patch)
2018-01-29 16:50 UTC, Leo Vandewoestijne
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Vandewoestijne 2018-01-03 09:20:38 UTC
Created attachment 189359 [details]
knot 2.6.4

There was a new knot release for the knot2.
This patch upgrades accordingly.

The need for gcc is now gone, and clang *should* work.
Despite an entire fresh install I was unable to use poudriere (due to python errors).
So I was unable to test other than amd64 (while the problem occured on < 11 && i386).
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2018-01-06 23:36:28 UTC
This does not build on i386 >= 11, sorry:

make[4]: stopped in /wrkdirs/usr/ports/dns/knot2/work/knot-2.6.4/src
--- knotc ---
libtool: link: cc -O2 -pipe -march=i686 -fstack-protector -isystem /usr/local/include -fno-strict-aliasing -Wall -Werror=format-security -Werror=implicit -Wstrict-prototypes -rdynamic -fstack-protector -o .libs/knotc utils/knotc/knotc-commands.o utils/knotc/knotc-estimator.o utils/knotc/knotc-interactive.o utils/knotc/knotc-process.o utils/knotc/knotc-main.o  ./.libs/libknotd.a -L/usr/local/lib /wrkdirs/usr/ports/dns/knot2/work/knot-2.6.4/src/zscanner/.libs/libzscanner.so -lurcu -latomic ./.libs/libcontrib.a ./.libs/libknotus.a /wrkdirs/usr/ports/dns/knot2/work/knot-2.6.4/src/.libs/libknot.so /wrkdirs/usr/ports/dns/knot2/work/knot-2.6.4/src/dnssec/.libs/libdnssec.so -ledit -lncurses -llmdb -lgnutls -lnettle -lpthread -lm -Wl,-rpath -Wl,/usr/local/lib
/usr/bin/ld: cannot find -latomic
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** [knotc] Error code 1

make[4]: stopped in /wrkdirs/usr/ports/dns/knot2/work/knot-2.6.4/src
--- keymgr ---
libtool: link: cc -O2 -pipe -march=i686 -fstack-protector -isystem /usr/local/include -fno-strict-aliasing -Wall -Werror=format-security -Werror=implicit -Wstrict-prototypes -fstack-protector -o .libs/keymgr utils/keymgr/keymgr-bind_privkey.o utils/keymgr/keymgr-functions.o utils/keymgr/keymgr-main.o  ./.libs/libknotd.a -L/usr/local/lib /wrkdirs/usr/ports/dns/knot2/work/knot-2.6.4/src/zscanner/.libs/libzscanner.so -lurcu -latomic ./.libs/libcontrib.a ./.libs/libknotus.a /wrkdirs/usr/ports/dns/knot2/work/knot-2.6.4/src/.libs/libknot.so /wrkdirs/usr/ports/dns/knot2/work/knot-2.6.4/src/dnssec/.libs/libdnssec.so -ledit -lncurses dnssec/.libs/libdnssec.so dnssec/.libs/libshared.a zscanner/.libs/libzscanner.so -llmdb -lgnutls -lnettle -lpthread -lm -Wl,-rpath -Wl,/usr/local/lib
/usr/bin/ld: cannot find -latomic
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** [keymgr] Error code 1
Comment 2 Leo Vandewoestijne 2018-01-29 16:50:35 UTC
Created attachment 190164 [details]
update knot2 + patch atomic i386

Got a new laptop and was able to replicate the problem.
Meanwhile Daniel Salzman already came with a patch that solved the problem.
It will be included starting next release.
For this release I made this new patch that includes them.
Patch was tested manually (as ยง3.4 of the porters handbook).
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-02-03 08:54:39 UTC
A commit references this bug:

Author: riggs
Date: Sat Feb  3 08:54:23 UTC 2018
New revision: 460797
URL: https://svnweb.freebsd.org/changeset/ports/460797

Log:
  Update to upstream version 2.6.4

  PR:		224858
  Submitted by:	freebsd@dns-lab.com (maintainer)
  MFH:		2018Q1

Changes:
  head/dns/knot2/Makefile
  head/dns/knot2/distinfo
  head/dns/knot2/dns/
  head/dns/knot2/dns/knot2/
  head/dns/knot2/dns/knot2/files/
  head/dns/knot2/dns/knot2/files/extra-patch-configure.ac
  head/dns/knot2/dns/knot2/files/extra-patch-src_Makefile.am
  head/dns/knot2/files/extra-patch-configure.ac
  head/dns/knot2/files/extra-patch-src_Makefile.am
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-02-04 13:59:40 UTC
A commit references this bug:

Author: riggs
Date: Sun Feb  4 13:58:48 UTC 2018
New revision: 460931
URL: https://svnweb.freebsd.org/changeset/ports/460931

Log:
  MFH: r460797

  Update to upstream version 2.6.4

  PR:		224858
  Submitted by:	freebsd@dns-lab.com (maintainer)

  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2018Q1/
  branches/2018Q1/dns/knot2/Makefile
  branches/2018Q1/dns/knot2/distinfo
  branches/2018Q1/dns/knot2/dns/
  branches/2018Q1/dns/knot2/files/extra-patch-configure.ac
  branches/2018Q1/dns/knot2/files/extra-patch-src_Makefile.am