Bug 225020 - www/qt5-webengine obj/QtWebEngineCore/file_picker_controller.o ninja: build stopped: subcommand failed
Summary: www/qt5-webengine obj/QtWebEngineCore/file_picker_controller.o ninja: build s...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-09 01:51 UTC by Marco Beishuizen
Modified: 2018-01-09 20:43 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments
complete portupgrade log (135.55 KB, application/x-xz)
2018-01-09 18:12 UTC, Vladimir Omelchuk
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Beishuizen 2018-01-09 01:51:51 UTC
Building www/qt5-webengine results in an error:

[...]
[16251/16328] CXX obj/QtWebEngineCore/download_manager_delegate_qt.o
In file included from /usr/ports/www/qt5-webengine/work/qtwebengine-opensource-src-5.9.3/src/core/download_manager_delegate_qt.cpp:59:
/usr/ports/www/qt5-webengine/work/qtwebengine-opensource-src-5.9.3/src/core/web_contents_delegate_qt.h:124:10: warning: 'QtWebEngineCore::WebContentsDelegateQt::BeforeUnloadFired' hides overloaded virtual function [-Woverloaded-virtual]
    void BeforeUnloadFired(content::WebContents* tab, bool proceed, bool* proceed_to_fire_unload) override;
         ^
../../../../qtwebengine-opensource-src-5.9.3/src/3rdparty/chromium/content/public/browser/web_contents_observer.h:444:16: note: hidden overloaded virtual function 'content::WebContentsObserver::BeforeUnloadFired' declared here: different number of parameters (1 vs 3)
  virtual void BeforeUnloadFired(const base::TimeTicks& proceed_time) {}

1 warning generated.
[16252/16328] CXX obj/QtWebEngineCore/file_picker_controller.o
ninja: build stopped: subcommand failed.
*** [run_ninja] Error code 1

make[5]: stopped in /usr/ports/www/qt5-webengine/work/.build/src/core
1 error

make[5]: stopped in /usr/ports/www/qt5-webengine/work/.build/src/core
*** [sub-gn_run-pro-make_first] Error code 2

make[4]: stopped in /usr/ports/www/qt5-webengine/work/.build/src/core
1 error

make[4]: stopped in /usr/ports/www/qt5-webengine/work/.build/src/core
*** [sub-core-make_first] Error code 2

make[3]: stopped in /usr/ports/www/qt5-webengine/work/.build/src
1 error

make[3]: stopped in /usr/ports/www/qt5-webengine/work/.build/src
*** [sub-src-make_first] Error code 2

make[2]: stopped in /usr/ports/www/qt5-webengine/work/.build
1 error

make[2]: stopped in /usr/ports/www/qt5-webengine/work/.build
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/www/qt5-webengine
*** Error code 1

Stop.
make: stopped in /usr/ports/www/qt5-webengine
[...]

My uname -a is:
FreeBSD yokozuna 11.1-STABLE FreeBSD 11.1-STABLE #0 r322753: Mon Aug 21 22:56:30 CEST 2017     root@yokozuna:/usr/obj/usr/src/sys/YOKOZUNA  amd64
Comment 1 Vladimir Omelchuk 2018-01-09 15:54:14 UTC
I have same error ...

# uname -srm
FreeBSD 11.1-RELEASE-p6 amd64
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2018-01-09 17:06:52 UTC
Hi there

I suspect it is picking up an old header from the install WebEngine. Could you upload the complete log.

(Or it picks up something we don't explicitly disable from the environment) 


Mfg Tobias
Comment 3 Marco Beishuizen 2018-01-09 17:58:47 UTC
Sorry I cleaned the portstree already to upgrade other parts. And since it takes 12 hours to build on my machine I can't easily reproduce it. Only thing I can say is that I cleaned the system and portstree before upgrading. I tried upgrading qt5-webengine twice and in both instances it failed at object 16252 (of 16341?) after 12 hours compiling with the same error.
Comment 4 Vladimir Omelchuk 2018-01-09 18:12:01 UTC
Created attachment 189564 [details]
complete portupgrade log

(In reply to Tobias C. Berner from comment #2)

Done.
Comment 5 Tobias C. Berner freebsd_committer freebsd_triage 2018-01-09 18:42:45 UTC
(In reply to Vladimir Omelchuk from comment #4)

Ok I think it is as I was suspecting picking up the old Qt5WebEngine (see the -I/usr/local/include/qt5/QtWebengineCore in your log) headers and getting confused. 

I would suggest to 
* deinstall qt5-webengine and then install it from source 
 or
* switch to a clean-world buildsystem like poudriere




mfg Tobias
Comment 6 Marco Beishuizen 2018-01-09 18:52:27 UTC
(In reply to Tobias C. Berner from comment #5)
Ok but shouldn't this be in /usr/ports/UPDATING to deinstall qt5-webengine first before upgrading?
Comment 7 Tobias C. Berner freebsd_committer freebsd_triage 2018-01-09 18:55:52 UTC
Yes probably :) -- we simply didn't know about the issue yet -- also ideally, it would just work [tm].
Comment 8 Marco Beishuizen 2018-01-09 18:59:21 UTC
Ok thanks for the help.
I'll try to reinstall later since it takes so much time.

Regards,
Marco
Comment 9 Vladimir Omelchuk 2018-01-09 19:24:29 UTC
(In reply to Tobias C. Berner from comment #5)

Yes, you are right.
New install from port was successful.
Thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2018-01-09 20:41:51 UTC
A commit references this bug:

Author: tcberner
Date: Tue Jan  9 20:41:19 UTC 2018
New revision: 458568
URL: https://svnweb.freebsd.org/changeset/ports/458568

Log:
  Document issues during the upgrade of www/qt5-webengine

  PR:		225020
  Reported by:	Marco Beishuizen <mbeis@xs4all.nl>, Vladimir Omelchuk <admin@vladiom.com.ua>

Changes:
  head/UPDATING
Comment 11 Tobias C. Berner freebsd_committer freebsd_triage 2018-01-09 20:43:22 UTC
I close this with "fixed" as "works as intended" feels even worse :)


mfg Tobias