Created attachment 189622 [details] Update to 2.3.2 Changelog: https://github.com/sabnzbd/sabnzbd/releases/tag/2.3.2
Thanks for submitting this. I'll try to test your diff by this weekend. I am thinking we should also specifically require version 3.3.1 or higher for sabyenc. I believe the below could work. ${PYTHON_PKGNAMEPREFIX}sabyenc>=3.3.1:news/py-sabyenc@${PY_FLAVOR}
Created attachment 189693 [details] Update to 2.3.2 (and add minimum version to py-sabyenc dependency)
According to the following the minimum version of py-sabyenc is 3.3.2: sabnzbd/constants.py:SABYENC_VERSION_REQUIRED = '3.3.2'
weird, maybe im reading the changelog wrong. see the second point here https://github.com/sabnzbd/sabnzbd/releases/tag/2.3.2
i think this commit is relevant. https://github.com/sabnzbd/sabnzbd/commit/5ca66bfeef33509955ea18569cf8d3113a3fa9f6 i believe sabnzbd only checks for the first two numbers now. 3.3.x
Created attachment 189738 [details] Update to 2.3.2 (and set minimum version for py-sabyenc to 3.3.1) You're right. I only looked at the required version, but the final check only looks at the first three position of that version. Replaced the patch (hopefully for the last time) which sets the mimnimum version to 3.3.1.
Hey, i'm not sure if this is now maintainer approved or not. Should I go ahead and commit it, or wait for a formal approval? FWIW, I've been running with this for a few days without problems. Florian
I haven't had a chance to test it yet. I should have time tonight and I can post back.
Comment on attachment 189738 [details] Update to 2.3.2 (and set minimum version for py-sabyenc to 3.3.1) Worked well for me. Thanks!
A commit references this bug: Author: flo Date: Sat Jan 20 17:37:33 UTC 2018 New revision: 459531 URL: https://svnweb.freebsd.org/changeset/ports/459531 Log: Update to 2.3.2 PR: 225075 Submitted by: Ralf van der Enden <tremere@cainites.net> Approved by: maintainer Changes: head/news/sabnzbdplus/Makefile head/news/sabnzbdplus/distinfo head/news/sabnzbdplus/pkg-plist
Comitted. Thanks