Portscout printed this: > Bad limitw value provided by portconfig variable in port devel/pecl-weakref Please fix! Thanks, Yuri
Why is this not a bug?
Sorry, But this looks like a bug to me. portscout complains about the PORTSCOUT tag. The tag is places solely for the portscout consumption, and it doesn't like it. :-) Yuri
Good catch, Joneum, can you fix it: https://github.com/freebsd/portscout/blob/master/docs/portscout-portconfig.txt#L28 mfg Tobias
@reporter: please upload a patch when you open a PR. Thanks
Jochen, You can't expect reporters to send fixes for every problem they find. Finding a problem and reporting it is already a contribution. You as a maintainer should know best how to fix problems in your ports. Regards, Yuri
What exactly is it that bothers you? Why does it bother you that I get PORTSCOUT wrong? Do you always open PRs without a patch?
(In reply to Jochen Neumeister from comment #6) Nothing bothers me at all, thanks for asking. I just reported a bug, that's all. Yuri
Section 5.5. MAINTAINER of the Porters Handbook says: > A maintainer volunteers to keep a port in good working order. Maintainers have the primary responsibility for their ports, but not exclusive ownership. According to this, you have the primary responsibility, not submitters. https://www.freebsd.org/doc/en/books/porters-handbook/makefile-maintainer.html
and i say, PORTSCOUT is not a bug. I will wait 2 weeks for a patch, and is there nothing, i closed here
Moin moin Jochen, limitw is to limit between odd and even version numbers for example if the odd ones are always 'experimental' releases, you can make portscout only complain if there are new even versions inbound. I think for example Gnome uses that scheme, where 3.20 is stable and 3.21 is preview. Portscout has 'limitw:<position>:<even/oddness>' Now, what you want is to tell portscout, it should only bug you if there is a 0.x.y available with a leading 0. For this, portscout has "limit:<version-regex>". The regex you have already looks correct, but you used the wrong portscout limit-variable -- if you switch it from 'limitw' to 'limit', everything should work as it should [tm]. mfg Tobias
Then Yuri has the necessary info for the patch, because it bothers him
Created attachment 190603 [details] v1
A commit references this bug: Author: joneum Date: Sun Feb 25 18:05:52 UTC 2018 New revision: 462972 URL: https://svnweb.freebsd.org/changeset/ports/462972 Log: fix portscout PR: 225087 Reported by: yuri Changes: head/devel/pecl-weakref/Makefile