Bug 225107 - acme.sh depends on socat, even though there is no dependency specified in the port
Summary: acme.sh depends on socat, even though there is no dependency specified in the...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dan Langille
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-12 14:10 UTC by Ed Schouten
Modified: 2018-01-13 20:49 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Schouten freebsd_committer freebsd_triage 2018-01-12 14:10:33 UTC 
I just installed acme.sh using `pkg install acme.sh`. After installation, it fails as follows:

$ acme.sh --issue --standalone -d example.com 
[Fri Jan 12 15:10:04 CET 2018] Please install socat tools first.
[Fri Jan 12 15:10:04 CET 2018] _on_before_issue.

Installing the socat port fixes this.
Comment 1 Dan Langille freebsd_committer freebsd_triage 2018-01-12 14:43:20 UTC 
What version of acme.sh?

I ask because we added socat support: https://svnweb.freebsd.org/ports?view=revision&revision=457087

Perhaps it is wrong.

What is the output of pkg info acme.sh please?
Comment 2 Ed Schouten freebsd_committer freebsd_triage 2018-01-12 14:47:17 UTC 
It looks like STANDALONE defaults to off:

$ pkg info acme.sh
...
Options        :
        BINDTOOLS      : off
        CURL           : on
        DOCS           : on
        STANDALONE     : off
        WGET           : off
...


Would it make sense to set it to 'on' by default? It's pretty useful to have standalone support readily available, as it's useful for spinning up new domains on systems that don't run a web server yet.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-01-13 20:47:45 UTC 
A commit references this bug:

Author: dvl
Date: Sat Jan 13 20:47:25 UTC 2018
New revision: 458941
URL: https://svnweb.freebsd.org/changeset/ports/458941

Log:
  Set STANDALONE default to ON by default.
  This pulls in net/socat

  PR:		225107
  Submitted by:	Ed Schouten <ed@FreeBSD.org>

Changes:
  head/security/acme.sh/Makefile
Comment 4 Dan Langille freebsd_committer freebsd_triage 2018-01-13 20:49:23 UTC 
Sounds reasonable.  Done.