Bug 225221 - x11-toolkits/scintilla & editors/scite: Update to 4.0.2
Summary: x11-toolkits/scintilla & editors/scite: Update to 4.0.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-16 16:00 UTC by Naram Qashat
Modified: 2018-02-23 07:46 UTC (History)
1 user (show)

See Also:


Attachments
scintilla-4.0.2.patch (2.75 KB, patch)
2018-01-16 16:00 UTC, Naram Qashat
cyberbotx: maintainer-approval+
Details | Diff
scite-4.0.2.patch (1.05 KB, patch)
2018-01-16 16:00 UTC, Naram Qashat
cyberbotx: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2018-01-16 16:00:01 UTC
Created attachment 189802 [details]
scintilla-4.0.2.patch

* Update both scintilla and scite to 4.0.2
* Updated distinfo for both
* Updated patch-makefile for scintilla

Changelogs:

Scintilla: http://www.scintilla.org/ScintillaHistory.html
Scite: http://www.scintilla.org/SciTE.html (there is no extensive list, just the small list on that page)

Tested with poudriere for 10-i386, 10-amd64, 11-i386 and 11-amd64. portlint shows no problems.
Comment 1 Naram Qashat 2018-01-16 16:00:37 UTC
Created attachment 189803 [details]
scite-4.0.2.patch
Comment 2 Naram Qashat 2018-02-23 04:50:42 UTC
Before this gets committed, I actually want to change it to update to 4.0.3, but I need to verify it compiles fine first, so please wait on that, thank you.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2018-02-23 04:53:31 UTC
(In reply to Naram Qashat from comment #2)

Ok, thanks, I will wait.

Yuri
Comment 4 Naram Qashat 2018-02-23 07:22:35 UTC
Change of plans, go ahead and commit these ones. At the moment I can't get version 4.0.3 of Scintilla to compile under FreeBSD 10 (not sure about 11 yet) because it has changed to using C++17 and the compile fails due to them using std::clamp, which wasn't introduced until C++17. When I figure out how to compile them, I'll submit a separate bug report.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2018-02-23 07:25:05 UTC
(In reply to Naram Qashat from comment #4)

Ok, thank you for letting me know.
I will proceed then.
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-02-23 07:46:05 UTC
A commit references this bug:

Author: yuri
Date: Fri Feb 23 07:46:00 UTC 2018
New revision: 462677
URL: https://svnweb.freebsd.org/changeset/ports/462677

Log:
  x11-toolkits/scintilla editors/scite: Update to 4.0.2

  Also changed to DISTVERSION.

  PR:		225221
  Submitted by:	Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)
  Approved by:	tcberner (mentor, implicit)

Changes:
  head/editors/scite/Makefile
  head/editors/scite/distinfo
  head/x11-toolkits/scintilla/Makefile
  head/x11-toolkits/scintilla/distinfo
  head/x11-toolkits/scintilla/files/patch-makefile
  head/x11-toolkits/scintilla/pkg-plist
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2018-02-23 07:46:16 UTC
Committed with small changes.
Thank you for your update!