Bug 225303 - multimedia/py-soco needs py-xmltodict dependency
Summary: multimedia/py-soco needs py-xmltodict dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Some People
Assignee: Bruce A. Mah
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-18 18:13 UTC by Bruce A. Mah
Modified: 2018-01-22 01:13 UTC (History)
1 user (show)

See Also:
bmah: maintainer-feedback+

Attachments
Patch to fix bug. (631 bytes, patch)
2018-01-18 18:13 UTC, Bruce A. Mah 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bruce A. Mah freebsd_committer freebsd_triage 2018-01-18 18:13:16 UTC 
Created attachment 189889 [details]
Patch to fix bug.

py-soco's requirements.txt lists xmltodict as a dependency, but the port doesn't list this in its RUN_DEPENDS.  I realized this when a nightly cronjob that I run started failing a few weeks (?) ago complaining that it couldn't import xmltodict.  Patch attached.

I can commit this patch if the maintainer approves.
Comment 1 Conall O'Brien 2018-01-21 23:41:15 UTC 
(In reply to Bruce A. Mah from comment #0)

Maintainer approval.


Thank you for noticing and submitting a fix
Comment 2 Bruce A. Mah freebsd_committer freebsd_triage 2018-01-22 01:07:21 UTC 
Take.
Comment 3 Bruce A. Mah freebsd_committer freebsd_triage 2018-01-22 01:08:02 UTC 
Maintainer gave approval in bug comment, so set appropriate flag.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-01-22 01:12:12 UTC 
A commit references this bug:

Author: bmah
Date: Mon Jan 22 01:11:55 UTC 2018
New revision: 459633
URL: https://svnweb.freebsd.org/changeset/ports/459633

Log:
  Add required but formerly-missing dependency on xmltodict.
  Pet PORTREVISION because it packaged before, but didn't always run
  correctly.

  PR:		225303
  Approved by:	Conall O'Brien <conall@conall.net> (maintainer)

Changes:
  head/multimedia/py-soco/Makefile
Comment 5 Bruce A. Mah freebsd_committer freebsd_triage 2018-01-22 01:13:09 UTC 
All done.  Thanks to the MAINTAINER for the quick review/approval!