Bug 225407 - [PATCH] deskutils/spice-gtk: fix build with LibreSSL
Summary: [PATCH] deskutils/spice-gtk: fix build with LibreSSL
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-01-23 17:05 UTC by Pawel Pekala
Modified: 2018-02-07 15:57 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (olevole)


Attachments
libressl fix (1.76 KB, patch)
2018-01-23 17:05 UTC, Pawel Pekala
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pekala freebsd_committer freebsd_triage 2018-01-23 17:05:52 UTC
Created attachment 190005 [details]
libressl fix

spice-gtk fails to build with LibreSSL:

./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_meth_set_read'
./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_get_data'
./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_meth_set_write'
./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_meth_set_ctrl'
./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_meth_set_puts'
./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_meth_free'
./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_meth_new'
./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_set_init'
./.libs/libspice-client-glib-2.0.so: undefined reference to `EVP_PKEY_get0_RSA'
./.libs/libspice-client-glib-2.0.so: undefined reference to `ASN1_STRING_get0_data'
./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_get_new_index'
./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_set_data'
cc: error: linker command failed with exit code 1 (use -v to see invocation)

Proposed patches were submitted and accepted by upstream:

https://lists.freedesktop.org/archives/spice-commits/2018-January/004276.html
https://lists.freedesktop.org/archives/spice-commits/2018-January/004277.html
Comment 1 Ben Woods freebsd_committer freebsd_triage 2018-01-31 10:00:02 UTC
I can confirm this patch fixed the spice-gtk build issue with libressl for me on FreeBSD 12-current r326012.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-02-07 15:56:26 UTC
A commit references this bug:

Author: pawel
Date: Wed Feb  7 15:55:49 UTC 2018
New revision: 461150
URL: https://svnweb.freebsd.org/changeset/ports/461150

Log:
  Fix build with LibreSSL:

  ./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_meth_set_read'
  ./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_get_data'
  ./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_meth_set_write'
  ./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_meth_set_ctrl'
  ./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_meth_set_puts'
  ./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_meth_free'
  ./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_meth_new'
  ./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_set_init'
  ./.libs/libspice-client-glib-2.0.so: undefined reference to `EVP_PKEY_get0_RSA'
  ./.libs/libspice-client-glib-2.0.so: undefined reference to `ASN1_STRING_get0_data'
  ./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_get_new_index'
  ./.libs/libspice-client-glib-2.0.so: undefined reference to `BIO_set_data'
  cc: error: linker command failed with exit code 1 (use -v to see invocation)

  Patches were submitted and accepted by upstream:

  https://lists.freedesktop.org/archives/spice-commits/2018-January/004276.html
  https://lists.freedesktop.org/archives/spice-commits/2018-January/004277.html

  PR:		225407
  Submitted by:	myself
  Approved by:	maintainer timeout

Changes:
  head/deskutils/spice-gtk/files/patch-libressl