Bug 225537 - graphics/pfstools - update to 2.1.0 release
Summary: graphics/pfstools - update to 2.1.0 release
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords:
: 213941 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-01-29 17:20 UTC by Iouri V. Ivliev
Modified: 2018-03-20 06:33 UTC (History)
3 users (show)

See Also:
fbsd: maintainer-feedback+

Attachments
update graphics/pfstools port to 2.1.0 release (291.84 KB, patch)
2018-01-29 17:20 UTC, Iouri V. Ivliev 		fbsd: maintainer-approval+
Details | Diff
update graphics/pfstools port to 2.1.0 release (291.67 KB, patch)
2018-01-30 14:16 UTC, Iouri V. Ivliev 		fbsd: maintainer-approval+
Details | Diff
patch-to-2.1.0 (321.01 KB, patch)
2018-02-24 22:59 UTC, Yuri Victorovich 		no flags Details | Diff
update graphics/pfstools port to 2.1.0 release (291.96 KB, patch)
2018-02-25 03:08 UTC, Iouri V. Ivliev 		fbsd: maintainer-approval+
Details | Diff
update graphics/pfstools port to 2.1.0 release (81.69 KB, patch)
2018-02-26 15:03 UTC, Iouri V. Ivliev 		fbsd: maintainer-approval+
Details | Diff
update graphics/pfstools port to 2.1.0 release (82.75 KB, patch)
2018-03-01 13:49 UTC, Iouri V. Ivliev 		fbsd: maintainer-approval+
Details | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Iouri V. Ivliev 2018-01-29 17:20:06 UTC 
Created attachment 190165 [details]
update graphics/pfstools port to 2.1.0 release

Major changes since 1.8.5:
* pfscalibration and pfstmo are a parts of pfstoos source archive now. So graphics/pfscalibration and graphics/pfstmp ports should be marked as deprecated;
* new tone-mapping operators: pfstmo_mai11, pfstmo_ferradans11;
* new filters pfsinyuv/pfsoutyuv to handle uncompressed video .yuy;
* pfsview uses Qt5 as a GUI toolkit.
Port changes:
* some options was added/removed, defaults was changed;
* when OCTAVE option selected, port installs two additional octave scripts to manipulate with saved pfshdrcalibrate response curves: pfssmoothresp, pfsplotresp; see man pages for details;
* as new implementation of robertson02 automatic self-calibration method still unstable, "robertson-old" method was added to pfshdrcalibrate; see pfshdrcalibrate(1) man page for details;
* 'gauss' weighting function (was dropped since pfscalibration 1.5) returned back; new option '--weights' was added for pfshdrcalibrate to select weighting function; see pfshdrcalibrate(1) man page for details;
* some functionality was changed/added for pfsinimgmagick/pfsoutimgmagick file formats; see man pages for details.
Comment 1 Ben Woods freebsd_committer freebsd_triage 2018-01-29 22:27:45 UTC 
*** Bug 213941 has been marked as a duplicate of this bug. ***
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2018-01-30 13:43:34 UTC 
>-# Created by: Daniel O'Connor <darius@dons.net.au>
>+# Created by: Iouri V. Ivliev
This change is wrong, please retain original author of the port.
Comment 3 Iouri V. Ivliev 2018-01-30 14:16:04 UTC 
Created attachment 190199 [details]
update graphics/pfstools port to 2.1.0 release

Ok, "Created by" kept unchanged.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2018-02-24 22:52:20 UTC 
Iouri,

When I enable IMAGEMAGICK build fails:
/usr/ports/graphics/pfstools/work/pfstools-2.1.0/src/fileformat/pfsinimgmagick.cpp:108:39: error: unknown type name 'Quantum'; did you mean 'Magick::Quantum'?
  VERBOSE_STR << "quantum range: " << QuantumRange << std::endl;
                                      ^
/usr/local/include/ImageMagick-6/magick/magick-type.h:86:25: note: expanded from macro 'QuantumRange'
#define QuantumRange  ((Quantum) 65535)
                        ^
/usr/local/include/ImageMagick-6/Magick++/Include.h:283:21: note: 'Magick::Quantum' declared here
  using MagickCore::Quantum;
                    ^
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2018-02-24 22:59:54 UTC 
Created attachment 190977 [details]
patch-to-2.1.0

My current patch.
Comment 6 Iouri V. Ivliev 2018-02-25 03:08:58 UTC 
Created attachment 190978 [details]
update graphics/pfstools port to 2.1.0 release

Fixes up build when IMAGEMAGICK option was enabled and ImageMagick was compiled without HDRI support.
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2018-02-25 18:14:44 UTC 
Now you've deleted this part of the patch, which seems like it should be kept:
--- src/octave/pfsstat.orig	2017-11-13 17:38:28 UTC
+++ src/octave/pfsstat
@@ -1,4 +1,4 @@
-#!/usr/bin/octave -q
+#!/usr/local/bin/octave-cli -qf
 #  
 # This file is a part of PFSTOOLS package.
 #  ---------------------------------------------------------------------- 

I'll keep it.
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2018-02-25 19:30:09 UTC 
Where do files that are added under files/port/ come from?
Comment 9 Yuri Victorovich freebsd_committer freebsd_triage 2018-02-25 19:30:50 UTC 
(In reply to Yuri Victorovich from comment #8)

And why do they need to be added on the port level?
Comment 10 Iouri V. Ivliev 2018-02-25 21:01:31 UTC 
(In reply to Yuri Victorovich from comment #7)
This hunk is unnecessary. Shebangfix will do the same.
Comment 11 Iouri V. Ivliev 2018-02-25 21:33:52 UTC 
(In reply to Yuri Victorovich from comment #8)
src/camera/robertson02old.* contains an old implementation of robertson02 photometric calibration stolen from pfshdrcalibrate 1.4 (the new one gives strange results in most cases).
src/filter/pfswb.* and src/octave/* are my own tools.
Comment 12 Yuri Victorovich freebsd_committer freebsd_triage 2018-02-25 21:41:12 UTC 
(In reply to Iouri V. Ivliev from comment #11)

> src/filter/pfswb.* and src/octave/* are my own tools.

This is a problem. Port can't have custom tools just bundled with it. Such code should be put into a separate port.

> src/camera/robertson02old.* contains an old implementation of robertson02 photometric calibration stolen from pfshdrcalibrate 1.4 (the new one gives strange results in most cases).

There is a similar problem - it is not a job of the port to fix what is broken in the upstream version. Did you contact the upstream? Did they agree?

External code can't just be dropped into files/. It has to be extracted from the original tarballs when applicable. I am not sure if it is actually applicable in this case.
Comment 13 Iouri V. Ivliev 2018-02-26 15:02:38 UTC 
(In reply to Yuri Victorovich from comment #12)
As you wish.
Comment 14 Iouri V. Ivliev 2018-02-26 15:03:09 UTC 
Created attachment 191019 [details]
update graphics/pfstools port to 2.1.0 release

update graphics/pfstools port to 2.1.0 release

Major changes since 1.8.5:
* pfscalibration and pfstmo are a parts of pfstoos source archive now. So graphics/pfscalibration and graphics/pfstmp ports should be marked as deprecated;
* new tone-mapping operators: pfstmo_mai11, pfstmo_ferradans11;
* new filters pfsinyuv/pfsoutyuv to handle uncompressed video .yuy;
* pfsview uses Qt5 as a GUI toolkit.
Port changes:
* some options was added/removed, defaults was changed;
Comment 15 Iouri V. Ivliev 2018-03-01 13:49:40 UTC 
Created attachment 191102 [details]
update graphics/pfstools port to 2.1.0 release

Fixup build with octave 4.2.1
Comment 16 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-20 06:33:08 UTC 
Committed. with changes.
Thank you for the update!
Comment 17 commit-hook freebsd_committer freebsd_triage 2018-03-20 06:33:52 UTC 
A commit references this bug:

Author: yuri
Date: Tue Mar 20 06:33:02 UTC 2018
New revision: 465069
URL: https://svnweb.freebsd.org/changeset/ports/465069

Log:
  graphics/pfstools: Update to 2.1.0

  Port changes:
  * Change to DISTVERSION
  * Add LICENSE_FILE
  * Change to cmake (from gmake)
  * Update of all options accordingly

  PR:		225537
  Submitted by:	Iouri V. Ivliev <fbsd@any.com.ru> (maintainer)

Changes:
  head/graphics/pfstools/Makefile
  head/graphics/pfstools/distinfo
  head/graphics/pfstools/files/patch-CMakeLists.txt
  head/graphics/pfstools/files/patch-config.h.in
  head/graphics/pfstools/files/patch-configure
  head/graphics/pfstools/files/patch-src-fileformat-exrio.cpp
  head/graphics/pfstools/files/patch-src-fileformat-hdrtiffio.cpp
  head/graphics/pfstools/files/patch-src-fileformat-pfsinexr.cpp
  head/graphics/pfstools/files/patch-src-fileformat-pfsinimgmagick.cpp
  head/graphics/pfstools/files/patch-src-fileformat-pfsinjpeghdr.cpp
  head/graphics/pfstools/files/patch-src-fileformat-pfsoutimgmagick.cpp
  head/graphics/pfstools/files/patch-src-fileformat-pfsoutjpeghdr.cpp
  head/graphics/pfstools/files/patch-src-fileformat-pfsoutpfm.cpp
  head/graphics/pfstools/files/patch-src-fileformat-ppmio.cpp
  head/graphics/pfstools/files/patch-src-fileformat-rgbeio.cpp
  head/graphics/pfstools/files/patch-src-filter-Makefile.am
  head/graphics/pfstools/files/patch-src-filter-Makefile.in
  head/graphics/pfstools/files/patch-src-filter-pfscat.cpp
  head/graphics/pfstools/files/patch-src-filter-pfsclamp.cpp
  head/graphics/pfstools/files/patch-src-filter-pfsextractchannels.cpp
  head/graphics/pfstools/files/patch-src-filter-pfspanoramic.cpp
  head/graphics/pfstools/files/patch-src-filter-pfstag.cpp
  head/graphics/pfstools/files/patch-src-filter-pfswb.cpp
  head/graphics/pfstools/files/patch-src-hdrhtml-hdrhtml.cpp
  head/graphics/pfstools/files/patch-src-matlab-compatibility.h
  head/graphics/pfstools/files/patch-src-octave-pfsclose.cpp
  head/graphics/pfstools/files/patch-src-octave-pfsget.cpp
  head/graphics/pfstools/files/patch-src-octave-pfsopen.cpp
  head/graphics/pfstools/files/patch-src-octave-pfsput.cpp
  head/graphics/pfstools/files/patch-src-pfs-pfs.cpp
  head/graphics/pfstools/files/patch-src-pfs-pfs.h
  head/graphics/pfstools/files/patch-src-pfs-pfsutils.cpp
  head/graphics/pfstools/files/patch-src-pfsglview-picture_io.cpp
  head/graphics/pfstools/files/patch-src-pfsglview-picture_io.h
  head/graphics/pfstools/files/patch-src-pfsview-pfsview_widget.cpp
  head/graphics/pfstools/files/patch-src_camera_pfsalign.cpp
  head/graphics/pfstools/files/patch-src_fileformat_exrio.cpp
  head/graphics/pfstools/files/patch-src_fileformat_pfsoutpfm.cpp
  head/graphics/pfstools/files/patch-src_hdrhtml_hdrhtml.cpp
  head/graphics/pfstools/files/patch-src_octave_pfsstat
  head/graphics/pfstools/files/patch-src_pfs_CMakeLists.txt
  head/graphics/pfstools/files/patch-src_pfs_pfs.h
  head/graphics/pfstools/files/patch-src_pfs_pfsutils.cpp
  head/graphics/pfstools/files/patch-src_pfsglview_m__histogram.cpp
  head/graphics/pfstools/files/patch-src_pfsview_pfsview__widget.cpp
  head/graphics/pfstools/pkg-plist