Bug 225556 - graphics/ufraw: fails to build with clang 6.0
Summary: graphics/ufraw: fails to build with clang 6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-30 11:56 UTC by Dmitry Afanasiev
Modified: 2018-02-05 17:32 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (rodrigo)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Afanasiev 2018-01-30 11:56:16 UTC 
graphics/ufraw fails to on fresh HEAD with clang 6.0 with error message:
invalid suffix on literal; C++11 requires a space between literal and identifier

[some output skipped]
dcraw.cccc -DHAVE_CONFIG_H -I.  -I/usr/local/include  -I/usr/local/include -I/usr/local/include/gtk-2.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/libpng16 -I/usr/local/include/libdrm -I/usr/local/include/harfbuzz -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/atk-1.0 -D_THREAD_SAFE -pthread  -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -pthread  -I/usr/local/include  -I/usr/local/include -I/usr/local/include/lensfun -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include  -I/usr/local/include  -I/usr/local/include/libpng16   -DDCRAW_NOMAIN -DUFRAW_LOCALEDIR=\"/usr/local/share/locale\" -I/usr/local/include  -O2 -pipe -march=k8-sse3  -fstack-protector -fno-strict-aliasing  -MT ufraw_embedded.o -MD -MP -MF .deps/ufraw_embedded.Tpo -c -o ufraw_embedded.o ufraw_embedded.c
:10076:30: error: invalid suffix on literal; C++11 requires a space
      between literal and identifier [-Wreserved-user-defined-literal]
  strcpy (th->soft, "dcraw v"DCRAW_VERSION);

USE_CXXSTD=gnu++98 can be added to port's Makefile as workaround
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-02-05 17:26:31 UTC 
A commit references this bug:

Author: danfe
Date: Mon Feb  5 17:26:09 UTC 2018
New revision: 460986
URL: https://svnweb.freebsd.org/changeset/ports/460986

Log:
  Unbreak the build against recent Clang.

  PR:	225556

Changes:
  head/graphics/ufraw/files/patch-dcraw.cc
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2018-02-05 17:32:01 UTC 
Should be fixed as of ports r460986, thanks!