Bug 225680 - graphics/opencollada: fix build on arm
Summary: graphics/opencollada: fix build on arm
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Thomas Zander
URL: http://beefy8.nyi.freebsd.org/data/he...
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-02-05 11:07 UTC by Mikael Urankar
Modified: 2018-02-18 16:16 UTC (History)
2 users (show)

See Also:

Attachments
patch (2.67 KB, patch)
2018-02-05 11:07 UTC, Mikael Urankar 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2018-02-05 11:07:20 UTC 
Created attachment 190335 [details]
patch

patch from upstream:
https://github.com/KhronosGroup/OpenCOLLADA/commit/2d66943f7ce1ba92b3cc39ad11b5c82e6d3a538f

char is unsigned on arm.

I had to convert COLLADABUURI.cpp from dos EOL to unix EOL because I couldn't do a svn add files/patch-2d66943:
svn: E200009: File '/usr/local/poudriere/ports/default/graphics/opencollada/files/patch-2d66943' has inconsistent newlines
svn: E135000: Inconsistent line ending style
svn: E200042: Additional errors:

I don't know if it's the correct way to do it though.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-02-18 15:57:11 UTC 
A commit references this bug:

Author: riggs
Date: Sun Feb 18 15:56:44 UTC 2018
New revision: 462249
URL: https://svnweb.freebsd.org/changeset/ports/462249

Log:
  Fix build on arm

  Details:
  - Obtain patch-2d66943 from upstream head
  - Bump PORTREVISION
  - While on it: Pet portlint

  PR:		225680
  Submitted by:	mikael.urankar@gmail.com

Changes:
  head/graphics/opencollada/Makefile
  head/graphics/opencollada/files/patch-2d66943
Comment 2 Thomas Zander freebsd_committer freebsd_triage 2018-02-18 16:16:31 UTC 
Patch looks good, thanks!