Bug 225867 - [PATCH][ADOPT] games/xroach: fix reason for being BROKEN and new maintainer
Summary: [PATCH][ADOPT] games/xroach: fix reason for being BROKEN and new maintainer
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Romain Tartière
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-02-13 17:44 UTC by Philipp Engel
Modified: 2018-02-14 08:12 UTC (History)
1 user (show)

See Also:

Attachments
Patch to update the source code. (31.50 KB, text/plain)
2018-02-13 17:44 UTC, Philipp Engel 		no flags Details
Patch to update the Makefile and distinfo. (796 bytes, patch)
2018-02-13 17:45 UTC, Philipp Engel 		no flags Details | Diff
New distinfo. (119 bytes, text/plain)
2018-02-13 17:51 UTC, Philipp Engel 		no flags Details
svn patch (4.62 KB, patch)
2018-02-13 20:57 UTC, Philipp Engel 		no flags Details | Diff
new version (36.61 KB, patch)
2018-02-13 21:01 UTC, Philipp Engel 		no flags Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Engel 2018-02-13 17:44:22 UTC 
Created attachment 190583 [details]
Patch to update the source code.
Comment 1 Philipp Engel 2018-02-13 17:45:05 UTC 
Created attachment 190584 [details]
Patch to update the Makefile and distinfo.
Comment 2 Philipp Engel 2018-02-13 17:51:28 UTC 
Created attachment 190586 [details]
New distinfo.
Comment 3 Romain Tartière freebsd_committer freebsd_triage 2018-02-13 20:39:29 UTC 
Hi Philipp,

Can you please update this PR to provide a single patch conforming to the recommendations of the FreeBSD Porter's Handbook?

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#svn-diff

Thanks!
Comment 4 Philipp Engel 2018-02-13 20:57:23 UTC 
Created attachment 190594 [details]
svn patch

Hi Romain, hope that I've got it right.
Comment 5 Philipp Engel 2018-02-13 21:01:47 UTC 
Created attachment 190595 [details]
new version

Mercy me, I've forgotten the source code patch.
Comment 6 Romain Tartière freebsd_committer freebsd_triage 2018-02-13 21:04:32 UTC 
Excellent!  I'll give a look tomorrow
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-02-14 08:09:43 UTC 
A commit references this bug:

Author: romain
Date: Wed Feb 14 08:08:49 UTC 2018
New revision: 461766
URL: https://svnweb.freebsd.org/changeset/ports/461766

Log:
  Resurrect, unbreak and modernize games/xroach

  Submitter is also taking maintainership.

  PR:		225867
  Submitted by:	kidon@posteo.de

Changes:
  head/games/xroach/
  head/games/xroach/Makefile
  head/games/xroach/distinfo
  head/games/xroach/files/patch-Makefile
  head/games/xroach/files/patch-xroach.c
Comment 8 Romain Tartière freebsd_committer freebsd_triage 2018-02-14 08:12:42 UTC 
Thank you for resurrecting these cockroaches and taking maintainership!

A few notes for your future submissions:

- ports-mgmt/portlint can report a variety of problems, it's a good idea to ensure it does not report errors;
- You can set DEVELOPER=yes in /etc/make.conf so that more sanity checks are performed when you update ports.

I fixed the problems reported by these tools.  If you do not understand a change I made, feel free to ask me what happened ;-)