Bug 226455 - comms/picocom: Update to 3.1
Summary: comms/picocom: Update to 3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-08 16:56 UTC by Kai Knoblich
Modified: 2018-03-09 05:36 UTC (History)
1 user (show)

See Also:

Attachments
Patch for picocom 3.1 (1.64 KB, patch)
2018-03-08 16:56 UTC, Kai Knoblich 		no flags Details | Diff
Patch for picocom 3.1 - revision 2 (1.59 KB, patch)
2018-03-08 20:54 UTC, Kai Knoblich 		koobs: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2018-03-08 16:56:27 UTC 
Created attachment 191313 [details]
Patch for picocom 3.1

Hello,

the patch updates picocom to 3.1. The update from 2.2 to 3.1 is a major update which contains many improvements, e.g.:

- added custom baudrate support for FreeBSD, OpenBSD, and DragonflyBSD (in additions to Linux and MacOS that were already supported)

- standard input can now be a non-tty (e.g a file or a pipe).

- serial port output queue is now dynamically growable.

- now SIGINT, as well as SIGTERM, can kill picocom. May be useful when the standard input is not a tty.


Changes to the port:
- changed PORTVERSION to DISTVERSION
- replaced GH_ACCOUNT with GH_TUPLE
- removed files/patch-Makefile (patches to CFLAGS and CPPFLAGS are now included in upstream Makefile)


QA:
~~~
- poudriere (11.1Ramd64 + i386) -> OK
- portlint -> OK
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-08 17:26:14 UTC 
Why did you use 90385aa and not the tagged version 3.1?

Yuri
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2018-03-08 20:54:40 UTC 
Created attachment 191319 [details]
Patch for picocom 3.1 - revision 2

Hello Yuri,

hrm, the matter of habit. Anyway, you gave me the info that GH_TUPLE should be used only for adding extra projects/unbundling parts.

Therefor I created a revised patch which uses GH_ACCOUNT/GH_PROJECT instead.
--
Cheers
Kai
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2018-03-09 04:16:22 UTC 
Comment on attachment 191319 [details]
Patch for picocom 3.1 - revision 2

Port is unmaintained, implicit approval
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-09 05:35:51 UTC 
Committed.
Thank you for the update!
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-03-09 05:36:20 UTC 
A commit references this bug:

Author: yuri
Date: Fri Mar  9 05:35:45 UTC 2018
New revision: 463928
URL: https://svnweb.freebsd.org/changeset/ports/463928

Log:
  comms/picocom: Update to 3.1

  Port changes:
  * Changed to DISTVERSION
  * Added LICENSE_FILE
  * Removed the useless option DEBUG
  * Removed the patch

  PR:		226455
  Submitted by:	owk <freebsd_ports@k-worx.org>
  Approved by:	tcberner (mentor, implicit)

Changes:
  head/comms/picocom/Makefile
  head/comms/picocom/distinfo
  head/comms/picocom/files/