Bug 226524 - graphics/dspdfviewer fails to build on 11.1
Summary: graphics/dspdfviewer fails to build on 11.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://reviews.freebsd.org/D14652
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-11 13:02 UTC by Adriaan de Groot
Modified: 2018-03-20 13:59 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (santhosh.raju)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adriaan de Groot freebsd_committer freebsd_triage 2018-03-11 13:02:52 UTC 
../hyperlinkarea.cpp:35:18: error: zero as null pointer constant [-Werror,-Wzero-as-null-pointer-constant]
  if ( pixmap == 0 )
                 ^
                 nullptr

A patch is in the review. This build failer showed up while updating CMake to 3.11-rc3, which may have introduced other C++ flags by default.
Comment 1 Adriaan de Groot freebsd_committer freebsd_triage 2018-03-11 13:03:34 UTC 
Link to FreeBSD Phab review with the patch.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-03-20 13:02:11 UTC 
A commit references this bug:

Author: adridg
Date: Tue Mar 20 13:01:43 UTC 2018
New revision: 465086
URL: https://svnweb.freebsd.org/changeset/ports/465086

Log:
  Fix graphics/dspdfviewer build with modern Clang. The error message
  is in the (new) patch.

  PR:		226524
  Approved by:	tcberner (mentor, implicit)
  Differential Revision:	https://reviews.freebsd.org/D14652

Changes:
  head/graphics/dspdfviewer/files/patch-hyperlinkarea.cpp