Bug 226566 - Update from v1.1.1 to v1.1.2 of port: sysutils/ipdbtools - Tools for IP based Geo-blocking and Geo-routing
Summary: Update from v1.1.1 to v1.1.2 of port: sysutils/ipdbtools - Tools for IP based...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Yuri Victorovich
URL: https://github.com/cyclaero/ipdb
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-12 23:19 UTC by cyclaero
Modified: 2018-03-20 04:49 UTC (History)
1 user (show)

See Also:

Attachments
please ignore (2.17 KB, text/plain)
2018-03-12 23:19 UTC, cyclaero 		no flags Details
pleas ignore (2.17 KB, text/plain)
2018-03-13 19:37 UTC, cyclaero 		no flags Details
patch (894 bytes, patch)
2018-03-15 17:47 UTC, Yuri Victorovich 		no flags Details | Diff
Diff of the v1.1.2 compared to the v1.1.1 port directory (2.17 KB, patch)
2018-03-19 18:09 UTC, cyclaero 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description cyclaero 2018-03-12 23:19:28 UTC 
Created attachment 191459 [details]
please ignore

Switched the upstream to GitHub tagged releases
Fix building on ARM architectures
Various minor fixes and tweaks
Comment 1 cyclaero 2018-03-13 19:37:22 UTC 
Created attachment 191472 [details]
pleas ignore
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-15 16:29:56 UTC 
Please check the patch. It shows that every line has changed.
Comment 3 cyclaero 2018-03-15 16:45:41 UTC 
(In reply to Yuri Victorovich from comment #2)

Checked:

  clone /usr/ports/sysutils/ipdbtools sysutils_ipdbtools
  cd sysutils_ipdbtools
  patch -p1 -i ../ipdbtools-1.1.2-1.1.1.diff
  make install clean
  make deinstall
  make stage clean
  make package clean

Everything looks good. What's the problem?
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-15 17:31:47 UTC 
(In reply to cyclaero from comment #3)

I see, you reformatted the whole file. Never mind.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-15 17:47:19 UTC 
Created attachment 191525 [details]
patch

Hi cyclaero,

Since you seem to own the upstream repository, could you please apply the patch to the Makefile there so that we don't need to add it into the port?

It allows the caller to supply optimization/debug flags (CFLAGS).

Thanks!
Comment 6 cyclaero 2018-03-15 18:23:26 UTC 
(In reply to Yuri Victorovich from comment #5)

OK, I am going to do it. Now when I revisited the Makefile, I saw another obstacle, which might break installation of pre-built packages on some machines. On line 47 of the Makefile I got the flag -march=native. I assume it would be better to remove this, or won't this be a problem because the package building systems would ignore this anyway and users building from the ports would benefit from a better performance. Shall I remove this flag or may I leave it. Everything is ready for submitting the patch to GitHub and uploading a new diff for the port-files here. I am waiting only for your response.

Thank you very much for looking into this.

Best regards

Rolf
Comment 7 cyclaero 2018-03-19 18:09:56 UTC 
Created attachment 191636 [details]
Diff of the v1.1.2 compared to the v1.1.1 port directory

please ignore all the previous attachments
Comment 8 cyclaero 2018-03-19 18:12:21 UTC 
(In reply to Yuri Victorovich from comment #5)
As of your request, I improved the Makefile and re-created the release tag fo v1.1.2 on GitHub. I uploaded already the new diff for the v.1.1.2 release to the ports.
Comment 9 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-19 18:15:43 UTC 
(In reply to cyclaero from comment #8)

Thank you, I will take a look.

Yuri
Comment 10 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-20 04:48:52 UTC 
Committed.
Thank you for the update!
Comment 11 commit-hook freebsd_committer freebsd_triage 2018-03-20 04:49:28 UTC 
A commit references this bug:

Author: yuri
Date: Tue Mar 20 04:48:47 UTC 2018
New revision: 465063
URL: https://svnweb.freebsd.org/changeset/ports/465063

Log:
  sysutils/ipdbtools: Update to 1.1.2

  Port changes:
  * Rhange to github
  * Add LICENSE_FILE
  * Remove BROKEN_xx because these are now not broken
  * Remove post-patch

  PR:		226566
  Submitted by:	cyclaero@gmail.com (maintainer)

Changes:
  head/sysutils/ipdbtools/Makefile
  head/sysutils/ipdbtools/distinfo