Update graphics/py-pillow to 5.0.0 Changes: https://github.com/python-pillow/Pillow/blob/e5bd7eb6235cc24b9c8d3e7ce51ed48a780c7c70/CHANGES.rst Basic version bump update. Changelog shows no new dependencies. Poudriere testport ok - py27 FBSD11.1
Created attachment 191465 [details] Update graphics/py-pillow to 5.0.0 This time remembering the patch
Thank you Kevin. Does the test suite (make test) pass, and what if any backward incompatibility considerations have you come across (or noticed) for this major version update?
(In reply to Kubilay Kocak from comment #2) No, the test suite doesn't pass as is. I get a failure with: Traceback (most recent call last): File "selftest.py", line 8, in <module> from PIL import Image, ImageDraw, ImageFilter, ImageMath ImportError: No module named PIL *** Error code 1 Which would suggest the module isn't available at all. However, if I make install clean I have a functioning PIL module. Certainly a number of basic scripts I can use for testing the actual functionality work fine (basic functions such as crop, draw, convert, rotate). Given the test suite failed on importing the module I felt happy that specific error wasn't an issue in real-world usage. Unfortunately, I only use Pillow as a dependency for another set of tools that I use so I don't have much direct experience of Pillow and can't really comment on advanced functionality that the test suite presumably looks at, however once installed it seems to operate without error in my use case. There are backwards incompatible changes which seem well documented to assist user upgrades: https://pillow.readthedocs.io/en/latest/releasenotes/4.1.0.html#removed-deprecated-items https://pillow.readthedocs.io/en/latest/releasenotes/4.2.0.html#removed-deprecated-items https://pillow.readthedocs.io/en/latest/releasenotes/5.0.0.html#backwards-incompatible-changes
Actually, I take that back. Installing devel/py-nose makes the test suite run without errors. Oddly the current port fails make test citing nose was missing, so after installing that I tried 5.0.0 again and it passed: Ran 1104 tests in 18.777s OK (SKIP=169)
(In reply to Kevin Golding from comment #4) Thanks Kevin, I noticed after my original question that TEST_DEPENDS were missing from the port, which is what ensures test dependencies are installed for (and prior to running) the ports framework test target. Having said that, it also appears upstream have deprecated nose (in favour of pytest), so I've updated the test target accordingly. Still, very useful to have independent confirmation of it passing the test suite at your end too.
A commit references this bug: Author: koobs Date: Sat Mar 17 05:21:36 UTC 2018 New revision: 464756 URL: https://svnweb.freebsd.org/changeset/ports/464756 Log: graphics/py-pillow: Update to 5.0.0 - Update to 5.0.0 - Add TEST_DEPENDS, which was missing in previous port versions where test target was defined. - Switch to using pytest, per upstream. - Add comment to track actual (precise) supported Python versions. Release Notes: * https://pillow.readthedocs.io/en/latest/releasenotes/index.html Backward Incompatible Changes (5.0.0): * https://pillow.readthedocs.io/en/latest/releasenotes/5.0.0.html#backwards-incompatible-changes Detailed Changelog: * https://github.com/python-pillow/Pillow/blob/5.0.0/CHANGES.rst PR: 226573 [1] Submitted by: Kevin Golding <ports caomhin org> [1] Changes: head/graphics/py-pillow/Makefile head/graphics/py-pillow/distinfo
Committed with ports compliance / framework changes. Thanks Kevin!