Created attachment 191968 [details] misc/wmcalendar/files patch to properly initialize variables. There are three uninitialized bss variables that the current compiler does not zero. This causes the application to fail. The attached patch for the files directory corrects the problem.
(In reply to crahman from comment #0) > There are three uninitialized bss variables Global variables are already initialized to zero. I don't think this is right.
Created attachment 198442 [details] Fix array-out-of-bounds error. Correct loop iteration limits on an array manipulation.
This problem arose when lldb was imported into the base system, and at the time the debugger didn't work and I attributed the problem to yet another compiler error. Now I not only have faith in the compiler, but the debugger works. This made it easy to find and fix the problem - which was an array modification loop writing over other variables. The boundaries of the loop have been corrected in the new patch.
Comment on attachment 198442 [details] Fix array-out-of-bounds error. This seems ok to me. Still we should wait for maintainer approval again now.
(In reply to Tobias Kortkamp from comment #4) I'm okay with the change. Would you commit if possible?
(In reply to Soeren Straarup from comment #5) Please do the commit and QA yourself.
A commit references this bug: Author: tobik Date: Thu Jan 17 14:09:27 UTC 2019 New revision: 490563 URL: https://svnweb.freebsd.org/changeset/ports/490563 Log: misc/wmcalendar: Fix some out-of-bounds memory access PR: 227101 Submitted by: crahman@gmail.com Approved by: xride (maintainer) Changes: head/misc/wmcalendar/Makefile head/misc/wmcalendar/files/patch-wmCalendar.c
A commit references this bug: Author: tobik Date: Thu Jan 17 14:10:58 UTC 2019 New revision: 490564 URL: https://svnweb.freebsd.org/changeset/ports/490564 Log: MFH: r490563 misc/wmcalendar: Fix some out-of-bounds memory access PR: 227101 Submitted by: crahman@gmail.com Approved by: xride (maintainer) Approved by: ports-secteam runtime fix blanket Changes: _U branches/2019Q1/ branches/2019Q1/misc/wmcalendar/Makefile branches/2019Q1/misc/wmcalendar/files/patch-wmCalendar.c