Created attachment 192152 [details] Patch adding support for the new ${name}_limits mechanics (databases/percona57-server) Thanks to the recent change to rc.subr(8) it is no longer necessary to define a resource limiting logic in service scripts. limits(1) is now run by default and its configuration is handled via the "${name}_limits" variable. Unfortunately, there is a collision of variable names. The service scripts are broken on FreeBSD version with that new change (12.0-CURRENT, 11-STABLE and soon 11.2-RELEASE). It has been reported and diagnosed here.[2] I'm submitting a patch fixing the service script for this port. A similar patch has already been accepted by a maintainer of another database port.[2] The patch preserves the old behavior on the systems without the modification. It would be great if you could review the patch and test it. :) [1]: https://svnweb.freebsd.org/base?view=revision&revision=r328331 [2]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226907
Created attachment 192231 [details] Patch adding support for the new ${name}_limits mechanics (databases/percona57-server, revision: 1) The previous patch would fail to trigger the new ${name}_limits semantics for __FreeBSD_version 1101514. The new patch fixes it (thanks to mmokhi@).
Created attachment 192417 [details] Patch adding support for the new ${name}_limits mechanics (databases/percona57-server, revision: 4) Due to an increasing number of problems caused by the new ${name}_limits behavior, the revision, which was backported from 12-CURRENT to 11-STABLE, has now been reverted.[1] As a result, the new behavior will not be present in any FreeBSD version < 12. This new patch adapts the port to those latest changes. [1]: https://svnweb.freebsd.org/base?view=revision&revision=r332363
Grab.
A commit references this bug: Author: 0mp Date: Fri Nov 2 13:20:46 UTC 2018 New revision: 483806 URL: https://svnweb.freebsd.org/changeset/ports/483806 Log: databases/percona57-server: Adapt ${name}_limits to the new resource limiting mechanics for services Thanks to the recent change to rc.subr(8) it is no longer necessary to define a resource limiting logic in service scripts. limits(1) is now run by default and its configuration is handled via the "${name}_limits" variable. Unfortunately, there is a collision of variable names. The service scripts are broken on FreeBSD version with that new change (>= 12.0). The patch preserves the old behavior on the systems without the rc.subr(8) modification. PR: 227236 Reviewed by: krion Approved by: krion (mentor), maintainer timeout Differential Revision: https://reviews.freebsd.org/D17786 Changes: head/databases/percona57-server/Makefile head/databases/percona57-server/files/mysql-server.in