Bug 227269 - New port: textproc/ibus-uniemoji, a unicode/emoji input method
Summary: New port: textproc/ibus-uniemoji, a unicode/emoji input method
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-03 19:22 UTC by Val Packett
Modified: 2018-05-21 17:52 UTC (History)
1 user (show)

See Also:

Attachments
ibus-uniemoji.patch (2.08 KB, patch)
2018-04-03 19:22 UTC, Val Packett 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2018-04-03 19:22:24 UTC 
Created attachment 192180 [details]
ibus-uniemoji.patch
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-04-04 05:10:46 UTC 
Hi Greg,

I have a few questions:

* Why did you add USE_GNOME=glib20?
* Why did you add dependency on dbus?
* Why did you add 
RUN_DEPENDS=${LOCALBASE}/share/gir-1.0/IBus-1.0.gir:textproc/ibus ?

It never opens IBus-1.0.gir. but it opens /usr/local/lib/girepository-1.0/IBus-1.0.typelib. Shouldn't this file be there instead?

Thanks,
Yuri
Comment 2 Val Packett 2018-04-04 12:06:25 UTC 
(In reply to Yuri Victorovich from comment #1)

glib20 because:

from gi.repository import GLib
from gi.repository import GObject

dbus can be skipped I guess, it's used through the ibus library, not directly.

gir can be replaced with typelib, sure. I didn't check what exact file it loads.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2018-04-04 15:28:44 UTC 
(In reply to Greg V from comment #2)

These imports
> from gi.repository import GLib
> from gi.repository import GObject
don't come come from glib20.

Ok, thank you. I know how to change it now.

Yuri
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2018-05-21 17:15:36 UTC 
Committed.
Thank you for your contribution!
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-05-21 17:16:00 UTC 
A commit references this bug:

Author: yuri
Date: Mon May 21 17:15:31 UTC 2018
New revision: 470564
URL: https://svnweb.freebsd.org/changeset/ports/470564

Log:
  New port: textproc/ibus-uniemoji: Input method for entering unicode symbols and emoji by name

  PR:		227269
  Submitted by:	Greg V <greg@unrelenting.technology>

Changes:
  head/textproc/Makefile
  head/textproc/ibus-uniemoji/
  head/textproc/ibus-uniemoji/Makefile
  head/textproc/ibus-uniemoji/distinfo
  head/textproc/ibus-uniemoji/pkg-descr
  head/textproc/ibus-uniemoji/pkg-plist
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-05-21 17:52:33 UTC 
A commit references this bug:

Author: yuri
Date: Mon May 21 17:51:55 UTC 2018
New revision: 470566
URL: https://svnweb.freebsd.org/changeset/ports/470566

Log:
  textproc/ibus-uniemoji: Fix index breakage

  FLAVOR -> PY_FLAVOR

  PR:		227269

Changes:
  head/textproc/ibus-uniemoji/Makefile