Bug 227418 - devel/php-composer: Update to 1.6.3 and add flavors support
Summary: devel/php-composer: Update to 1.6.3 and add flavors support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL: https://reviews.freebsd.org/D15026
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-10 14:00 UTC by Guido Falsi
Modified: 2018-04-12 15:47 UTC (History)
1 user (show)

See Also:
cyberbotx: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2018-04-10 14:00:09 UTC 
I have updaated the port to 1.6.3 and added falvors support.

Filed the patch in phabricator for code review here:

https://reviews.freebsd.org/D15026

since flavors need portmgr approval and the flavorization introduces a package name change which renders pkg unable to automatically detect the update.

I have added an UPDATING entry for this, but maybe I'm missing some better solution.
Comment 1 Naram Qashat 2018-04-10 15:56:24 UTC 
The update looks fine to me. I can't think of a better way to do the update to allow flavors, so this seems like it'll work to me.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2018-04-10 16:05:28 UTC 
Thanks for your quick feedback.

I'll commit it once I get portmgr approval.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-04-12 15:39:27 UTC 
A commit references this bug:

Author: madpilot
Date: Thu Apr 12 15:39:22 UTC 2018
New revision: 467159
URL: https://svnweb.freebsd.org/changeset/ports/467159

Log:
  - Update php-composer to 1.6.3
  - Add php flavors support
  - Add updating note due to package name change

  PR:			227418
  Submitted by:		me
  Approved by:		cyberbotx@cyberbotx.com (maintainer),
  			portmgr (mat)
  Differential Revision:	https://reviews.freebsd.org/D15026

Changes:
  head/UPDATING
  head/devel/php-composer/Makefile
  head/devel/php-composer/distinfo
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2018-04-12 15:47:58 UTC 
Committed!