Bug 227571 - net-im/telegram-desktop: update to 1.2.17
Summary: net-im/telegram-desktop: update to 1.2.17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kirill Ponomarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-17 03:32 UTC by Henry Hu
Modified: 2018-04-17 15:25 UTC (History)
0 users

See Also:


Attachments
patch for the port (78.52 KB, patch)
2018-04-17 03:32 UTC, Henry Hu
henry.hu.sh: maintainer-approval+
Details | Diff
poudriere log on 11.1-STABLE/amd64 (49.92 KB, application/gzip)
2018-04-17 03:35 UTC, Henry Hu
no flags Details
poudriere log on 11.1-STABLE/i386 (52.36 KB, application/gzip)
2018-04-17 03:36 UTC, Henry Hu
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Hu 2018-04-17 03:32:48 UTC
Created attachment 192578 [details]
patch for the port

This patch updates telegram-desktop to 1.2.17.

Added an option for audio backend. Telegram itself uses OpenAL, but libtgvoip (for voice calls) uses either ALSA or PulseAudio. If both of them are not present, video calls do not work, but other functionalities are not affected.
The new option allows users to select whether they want to use ALSA or PulseAudio, or neither of them.

This new version uses features from C++17. Both language features and library features are used. Thus, I have not figured out a way to make it work on FreeBSD 10.
* The clang in base is 3.4.1 which is too old and does not support C++17.
* The clang in port is 5.0 which is good, but it lacks C++17 library features, like std::any.
* G++ supports C++17 language & library features, but other libraries like Qt are not compiled with G++. If you mix them, it causes segfaults due to mixed C++ runtime.
Thus, I marks it broken for <11. I'm looking for ways to solve this.
Comment 1 Henry Hu 2018-04-17 03:35:35 UTC
Created attachment 192579 [details]
poudriere log on 11.1-STABLE/amd64
Comment 2 Henry Hu 2018-04-17 03:36:43 UTC
Created attachment 192580 [details]
poudriere log on 11.1-STABLE/i386
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-04-17 14:11:29 UTC
A commit references this bug:

Author: krion
Date: Tue Apr 17 14:10:52 UTC 2018
New revision: 467607
URL: https://svnweb.freebsd.org/changeset/ports/467607

Log:
  Update to version 1.2.17

  PR:		227571
  Submitted by:	maintainer

Changes:
  head/net-im/telegram-desktop/Makefile
  head/net-im/telegram-desktop/distinfo
  head/net-im/telegram-desktop/files/gyp-patches
  head/net-im/telegram-desktop/files/patch-Telegram_Resources_qrc_telegram__linux.qrc
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles___other_packer.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_base_build__config.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_base_lambda.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_boxes_notifications__box.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_config.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_core_launcher.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_core_utils.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_data_data__document.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_history_admin__log_history__admin__log__inner.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_history_history__inner__widget.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_history_view_history__view__list__widget.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_layout.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_logs.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_main.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_mainwindow.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_linux_linux__libs.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_linux_linux__libs.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_linux_main__window__linux.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__audio.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__file__utilities.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__launcher.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__main__window.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__notifications__manager.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__specific.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__window__title.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_qt__functions.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_qt__static__plugins.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_settings.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_settings_settings__notifications__widget.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_structs.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_ui_text_text.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_ui_text_text__block.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_ui_twidget.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_ui_widgets_labels.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_window_main__window.h
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_VoIPController.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_audio_AudioInput.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_audio_AudioOutput.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_logging.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_linux_AudioInputALSA.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_linux_AudioInputPulse.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_linux_AudioOutputALSA.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_linux_AudioOutputPulse.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_linux_PulseAudioLoader.h
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_posix_NetworkSocketPosix.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_threading.h
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_webrtc__dsp_webrtc_base_stringutils.h
  head/net-im/telegram-desktop/files/patch-Telegram_gyp_PrecompiledHeader.cmake
  head/net-im/telegram-desktop/files/patch-Telegram_gyp_common.gypi
  head/net-im/telegram-desktop/files/patch-Telegram_gyp_settings__linux.gypi
  head/net-im/telegram-desktop/files/patch-Telegram_gyp_telegram__sources.txt
  head/net-im/telegram-desktop/files/patch-lib_xdg_tg.protocol
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2018-04-17 15:25:05 UTC
Assign to committer that resolved