Bug 227730 - [maintainer-update][patch] ports-mgmt/pkg_replace: update to 20180424
Summary: [maintainer-update][patch] ports-mgmt/pkg_replace: update to 20180424
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-24 01:24 UTC by Ken DEGUCHI
Modified: 2018-05-09 19:19 UTC (History)
2 users (show)

See Also:

Attachments
patch pkg_replace-20180424 (976 bytes, text/plain)
2018-04-24 01:24 UTC, Ken DEGUCHI 		no flags Details
patch pkg_replace-20180424 (portlint error fix) (1.02 KB, patch)
2018-04-24 23:03 UTC, Ken DEGUCHI 		no flags Details | Diff
patch pkg_replace-20180424 (add pkg-plist) (1.27 KB, patch)
2018-05-01 00:57 UTC, Ken DEGUCHI 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ken DEGUCHI 2018-04-24 01:24:33 UTC 
Created attachment 192766 [details]
patch pkg_replace-20180424

ports-mgmt/pkg_replace update to 20180424

-Cleanup code.
-Speed up and strictly check package's dependencies.
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2018-04-24 13:56:33 UTC 
Can you pet `portlint -AC`?
Comment 2 Ken DEGUCHI 2018-04-24 23:03:56 UTC 
Created attachment 192784 [details]
patch pkg_replace-20180424 (portlint error fix)

I created a new patch for portlint error fix.
Comment 3 Koichiro Iwao freebsd_committer freebsd_triage 2018-04-28 04:27:44 UTC 
`make clean package` fails. Could you also test it?

====> Running Q/A tests (stage-qa)
===>  Building package for pkg_replace-20180424
pkg-static: Plist error, directory listed as a file: 

Probably "@sample etc/${PORTNAME}/pkg_replace.conf.sample" in PLIST_FILES causing that. Please consider using pkg-plist instead of PLIST_FILES. You can use %%ETCDIR%% in pkg-plist file.

See also porter's handbook, 3.2.2. pkg-plist:
https://www.freebsd.org/doc/en/books/porters-handbook/porting-desc.html
Comment 4 Ken DEGUCHI 2018-05-01 00:57:00 UTC 
Created attachment 192944 [details]
patch pkg_replace-20180424 (add pkg-plist)

I created a new patch.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-05-06 10:15:55 UTC 
A commit references this bug:

Author: meta
Date: Sun May  6 10:15:04 UTC 2018
New revision: 469188
URL: https://svnweb.freebsd.org/changeset/ports/469188

Log:
  ports-mgmt/pkg_replace: Update to 20180424

  - Cleanup code
  - Speed up and strictly check package's dependencies
  - While here, pet portlint by using pkg-plist instead of PLIST_FILES

  PR:		227730
  Submitted by:	kdeguchi@sz.tokoha-u.ac.jp (maintainer)
  Approved by:    pi (mentor)

Changes:
  head/ports-mgmt/pkg_replace/Makefile
  head/ports-mgmt/pkg_replace/distinfo
  head/ports-mgmt/pkg_replace/pkg-plist
Comment 6 Koichiro Iwao freebsd_committer freebsd_triage 2018-05-06 10:19:23 UTC 
Sorry for the delay. Committed, thanks!
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2018-05-06 10:36:35 UTC 
danfe: Please note that one of the earlier versions of the patch caused this:

Something very surprising happens, if I build in poudriere:                     
                                                                                
cur [00:00:15] Error: Build failed in phase: package
111 [00:00:15] Error: Build failed in phase: package
104i [00:00:13] Error: Build failed in phase: package
                                                                                
All the builds fail with:                                                       

===>  Building package for pkg_replace-20180424
Child process pid=83138 terminated abnormally: Bus error
*** Error code 1
Comment 8 Jan Beich freebsd_committer freebsd_triage 2018-05-06 11:38:28 UTC 
(In reply to Kurt Jaeger from comment #7)
attachment 192784 [details] caused a packaging error because @sample keyword requires an argument (see /usr/ports/Keywords/sample.ucl). When double quotes were removed @sample ended up on a separate line in ${TMPPLIST} as if no argument was specified while the sample file was treated as regular file.
Comment 9 Jan Beich freebsd_committer freebsd_triage 2018-05-06 11:53:44 UTC 
Also, etc/${PORTNAME} is ${ETCDIR_REL}
Comment 10 Kurt Jaeger freebsd_committer freebsd_triage 2018-05-06 13:12:17 UTC 
(In reply to Jan Beich from comment #8)
Does that explain the bus error ?
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2018-05-09 19:19:26 UTC 
See

https://github.com/freebsd/pkg/issues/1680

for some details about the pkg(8) bus error issue.