Bug 227846 - [PATCH] x11/alacritty: Fix GL context error
Summary: [PATCH] x11/alacritty: Fix GL context error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Niclas Zeising
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-29 13:04 UTC by Sascha Holzleiter
Modified: 2018-05-05 18:57 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (zeising)


Attachments
alacritty srgb gl fix (1.07 KB, patch)
2018-04-29 13:04 UTC, Sascha Holzleiter
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Holzleiter 2018-04-29 13:04:32 UTC
Created attachment 192902 [details]
alacritty srgb gl fix

Starting alacritty on my 11.1-STABLE drm-next machine results in this error:

  Error creating GL context; Couldn't find any pixel format that matches the criterias.

The attached patch fixes that and was taken from https://github.com/jwilm/alacritty/issues/921 .

As this fix is already merged it would also suffice to update the port to a newer revision.
Comment 1 Niclas Zeising freebsd_committer freebsd_triage 2018-05-01 12:08:35 UTC
Looking at this.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-05-01 17:46:48 UTC
A commit references this bug:

Author: zeising
Date: Tue May  1 17:45:54 UTC 2018
New revision: 468774
URL: https://svnweb.freebsd.org/changeset/ports/468774

Log:
  Fix GL context creation

  Add patch from upstream to fix errors in creating GL context.
  See Upstream issue for details:
  https://github.com/jwilm/alacritty/issues/921

  PR:		227846
  Submitted by:	Sascha Holzleiter
  MFH:		2018Q2

Changes:
  head/x11/alacritty/Makefile
  head/x11/alacritty/files/
  head/x11/alacritty/files/patch-src_window.rs
Comment 3 Niclas Zeising freebsd_committer freebsd_triage 2018-05-01 17:47:40 UTC
Committed, thanks!

I'll look into updating the entire port, but for now, this issue should be solved.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-05-05 18:57:35 UTC
A commit references this bug:

Author: zeising
Date: Sat May  5 18:57:24 UTC 2018
New revision: 469158
URL: https://svnweb.freebsd.org/changeset/ports/469158

Log:
  MFH: r468774

  Fix GL context creation

  Add patch from upstream to fix errors in creating GL context.
  See Upstream issue for details:
  https://github.com/jwilm/alacritty/issues/921

  PR:		227846
  Submitted by:	Sascha Holzleiter

  Approved by:	ports-secteam (riggs)

Changes:
_U  branches/2018Q2/
  branches/2018Q2/x11/alacritty/Makefile
  branches/2018Q2/x11/alacritty/files/