Created attachment 192912 [details] add default config file and log rotation (via newsyslog) Revision: - Add a default config file (%%PREFIX%%/etc/urbackup/urbackupclient.conf) - Add log rotation (%%PREFIX%%/etc/newsyslog.conf.d/urbackupclient.conf)
Created attachment 192917 [details] add default config file and log rotation (via newsyslog) v2 Minor update to prior .diff to specify PID file in log rotation config
Created attachment 195921 [details] Update to 2.2.6; Add default config; Add log rotation A new version 2.2.6 was released since this PR was originally opened. This patch updates to 2.2.6, and retains the prior improvements (default config and log rotation).
@Kirk Thank you for the patch. Can you please confirm that the changes pass QA (portlint, poudriere at least). Also, don't forget to set the maintainer-approval flag to "+" on attachments for ports you are maintainer of. Attachment -> Details -> maintainer-approval [+]
(In reply to Kubilay Kocak from comment #3) @Kubilay, the port builds without error using "poudriere testport", and portlint produces some warnings* but no errors. I've set the maintainer-approval flag (thanks for letting me know I should do that). [*] The warnings suggest a NLS knob to due to use of gettext, and indicate that a couple of the patches contain ^M characters (based on those characters existing in the upstream sources).
(In reply to freebsd from comment #4) Thanks Kirk The only other thing I would suggest (to assist QA and understanding the changeset), it to add comments in each files/patch-* header to reference what the patch is for (what the issue is), and includes links to upstream bug reports, pull requests and/or commits, where available, to keep track.
Some of the new files/patch-client* files have DOS lineendings, and svn rejects them: svn: E200009: File '/home/pi/m/archivers/urbackup-client/files/patch-client_ConfigPath.cpp' has inconsistent newlines Can you try to get this consistent ?
Created attachment 196020 [details] Update to 2.2.6; Add default config; Add log rotation (removes dos line endings) New diff that addresses the dos line ending issue (I've added dos2unix to the uses line in the Makefile, and regenerated the patches). I've also added comments to the patches indicating their purpose, as suggested by Kubilay. No errors from portlint, and builds under poudriere. Overall changelog (vs committed port): * Update to 2.2.6 * Add a default configuration file * Add log rotation via newsyslog
Committed, thanks. With the next update, please try to silence portlint for the patch format.
A commit references this bug: Author: pi Date: Thu Aug 9 02:43:47 UTC 2018 New revision: 476717 URL: https://svnweb.freebsd.org/changeset/ports/476717 Log: archivers/urbackup-client: update 2.2.5 -> 2.2.6 - Add a default configuration file - Add log rotation via newsyslog PR: 227854 Submitted by: freebsd@coombscloud.com (maintainer) Reviewed by: koobs Relnotes: https://www.urbackup.org/client_changelog.html Changes: head/archivers/urbackup-client/Makefile head/archivers/urbackup-client/distinfo head/archivers/urbackup-client/files/patch-client_ConfigPath.cpp head/archivers/urbackup-client/files/patch-client_stringtools.cpp head/archivers/urbackup-client/files/patch-client_stringtools.h head/archivers/urbackup-client/files/pkg-message.in head/archivers/urbackup-client/files/urbackup_client.in head/archivers/urbackup-client/files/urbackupclient.conf-newsyslog head/archivers/urbackup-client/files/urbackupclient.conf.sample-daemon.in head/archivers/urbackup-client/pkg-plist