Bug 227896 - mail/amavis-logwatch: Fixes for new perl version
Summary: mail/amavis-logwatch: Fixes for new perl version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Danilo Egea Gondolfo
URL:
Keywords:
Depends on:
Blocks: 227895
  Show dependency tree / graph
 
Reported: 2018-05-01 12:06 UTC by Niclas Zeising
Modified: 2018-06-21 21:54 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danilo)

Attachments
amavis-logwatch perl fixes (2.52 KB, patch)
2018-05-01 12:06 UTC, Niclas Zeising 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Niclas Zeising freebsd_committer freebsd_triage 2018-05-01 12:06:20 UTC 
Created attachment 192965 [details]
amavis-logwatch perl fixes

Attached patch fixes mail/amavis-logwatch to work with the new perl version.
Comment 1 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2018-05-19 20:21:17 UTC 
Hello, Niclas. Thanks for submitting this patch.

Could you briefly explain why it's necessary, please? The same for PR 227895.

I'm not a Perl programmer :)

Thanks and sorry the delay!
Comment 2 Niclas Zeising freebsd_committer freebsd_triage 2018-06-17 15:36:23 UTC 
Hi!
Newever versions of perl gives syntax errors and the code won't execute without these changes.

Older versions gave warnings like this:
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/^(CLEAN|SPAM(?:MY)?|INFECTED \(.*?\)|BANNED \(.*?\)|BAD-HEADER(?:-\d)?|UNCHECKED|MTA-BLOCKED|OVERSIZED|OTHER|TEMPFAIL)(?: { <-- HERE [^}]+})?, ([^[]+ )?(?:([^<]+) )?[<(](.*?)[>)] -> ([(<].*?[)>]), (?:.*Hits: ([-+.\d]+))(?:.* size: (\d+))?(?:.* autolearn=(\w+))?/ at /usr/local/bin/amavis-logwatch line 2286.
Redundant argument in sprintf at /usr/local/bin/amavis-logwatch line 1338, <> line 20223.

But they have since been turned to errors.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-06-21 21:53:40 UTC 
A commit references this bug:

Author: danilo
Date: Thu Jun 21 21:53:00 UTC 2018
New revision: 473006
URL: https://svnweb.freebsd.org/changeset/ports/473006

Log:
  - Fix regex handling with the new perl version [1]

  [1] Unescaped left brace in regex is deprecated, passed through in regex

  PR:		227896
  Submitted by:	zeising

Changes:
  head/mail/amavis-logwatch/Makefile
  head/mail/amavis-logwatch/files/
  head/mail/amavis-logwatch/files/patch-amavis-logwatch
Comment 4 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2018-06-21 21:54:15 UTC 
Committed, thanks!