Created attachment 193024 [details] py-livereload-2.5.2.patch
Hello, attached is the patch that updates py-livereload to 2.5.2. Changes by upstream: - https://github.com/lepture/python-livereload/compare/v2.5.1...v2.5.2 QA: ~~~ - poudriere (11.1-RELEASE amd64 + i386) for each py27 + py36 flavor -> OK - portlint OK
A commit references this bug: Author: krion Date: Thu May 3 16:45:40 UTC 2018 New revision: 468939 URL: https://svnweb.freebsd.org/changeset/ports/468939 Log: Update to 2.5.2 PR: 227953 Submitted by: maintainer Changes: head/www/py-livereload/Makefile head/www/py-livereload/distinfo
Assign to committer that resolved. @Kirill Could you please assign yourself to issues you intend to resolve, ideally including previous issues you've resolved as well (that remain unassigned). That saves us having to do it manually. While I'm here, clear maintained-feedback flag, its only required if set to ? requesting feedback from the maintainer first.
(In reply to Kubilay Kocak from comment #3) Hello Kubilay, thank you for your hint with the maintainer-feedback flag. I won't use that flag anymore for new PRs of ports which I am maintainer of. I suppose, it's still ok to set the maintainer-approval flag for the attached patch because that flag was not removed from this PR? If so, I would continue using that flag on patches for ports that I maintain.
(In reply to Kai from comment #4) Absolutely use maintainer-approval, at least when you are the reporter of the change and maintainer of port being changed. It's how we 'explicitly' see a change is approved by its maintainer, and the flag will make the bug show up in the 'Ports: Maintainer Approved' list (look for it in the footer of bugzilla pages) for committers to easily find things 'ready' to work on. If you propose a change (patch/attachment) for a port you're *not* maintainer of, setting maintainer-approval ? <maintainer-email> on the attachment during creation/upload will allow the maintainer to set it to +, reducing the time to approval/resolution for everyone. If you have any more questions about bug tracking/triage/workflow, don't hesitate to ping us on IRC (#freebsd-bugs / freenode). I have a couple of links you might like
(In reply to Kubilay Kocak from comment #5) Thanks again for the info. I was about to ask on #freebsd-bugs because I was a bit confused about the "Maintainer approved list" you mentioned. This list had not been visible in the footer to me until recently. Thus I describe briefly my solution at this place to keep the context as a whole and for future reference for other users: 1. Go to "Preferences" (menu at the top) 2. Go to "Saved Searches" and enable the following searches: - "Ports: Maintainer Approved" - "Ports: Maintainer Timeout" - "Ports: Needs Triage (New)" 3. Save the new settings by "Submit changes" Maybe those searches could be enabled by default for new bugzilla users? By the way, the whole picture and the workflow of PRs is now much clearer for me than before. I still have a few questions but for that I'll stop on #freebsd-bugs soon.