Bug 228294 - security/py-certbot-nginx: replaces nginx root folder
Summary: security/py-certbot-nginx: replaces nginx root folder
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2018-05-16 14:20 UTC by Dhananjay Balan
Modified: 2018-05-17 18:31 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (python)

Attachments
replaces nginx root folder (22 bytes, patch)
2018-05-16 14:20 UTC, Dhananjay Balan 		no flags Details | Diff
replaces-nginx-rootfolder (886 bytes, patch)
2018-05-16 14:23 UTC, Dhananjay Balan 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dhananjay Balan 2018-05-16 14:20:20 UTC 
Created attachment 193459 [details]
replaces nginx root folder

Certbot Nginx plugin hardcodes nginx root to /etc/nginx. 

Patch rewrites it to /usr/local/etc/nginx

Ideally this should be a config entry. I'd check if you can land such a patch upstream.
Comment 1 Dhananjay Balan 2018-05-16 14:23:42 UTC 
Created attachment 193460 [details]
replaces-nginx-rootfolder
Comment 2 Dhananjay Balan 2018-05-16 17:47:58 UTC 
Looking closely nginx plugin exposes --server-root to change nginx root, but IMO its better to replace the default on FreeBSD systems.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-05-17 18:31:17 UTC 
A commit references this bug:

Author: sunpoet
Date: Thu May 17 18:30:55 UTC 2018
New revision: 470243
URL: https://svnweb.freebsd.org/changeset/ports/470243

Log:
  Fix nginx server root path

  - Bump PORTREVISION for package change

  PR:		228294
  Reported by:	Dhananjay Balan <mail@dbalan.in>

Changes:
  head/security/py-certbot-nginx/Makefile
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-05-17 18:31:42 UTC 
Committed. Thanks!