It seems to me that freebsd-ports/www/node/files/patch-deps_v8_src_base_cpu.cc is wrong since there is already an +#if V8_OS_LINUX enclosing the inserted one.
Yes, indeed, good catch! I will fix the patch when committing the upgrade to Node.js v10.4.0. Thanks! :)
Committed, thanks! :)
A commit references this bug: Author: bhughes Date: Fri Jun 8 18:43:12 UTC 2018 New revision: 472018 URL: https://svnweb.freebsd.org/changeset/ports/472018 Log: www/node: Update 10.3.0 -> 10.4.0 https://nodejs.org/en/blog/release/v10.4.0/ Remove files/patch-deps_v8_src_base_cpu.cc, which has been applied upstream and is no longer necessary (as reported in PR 228779). Other patches have been refreshed as needed with `make makepatch`. PR: 228779 Reported by: Sylvain Garrigues <sylvain@sylvaingarrigues.com> Sponsored by: Miles AS Changes: head/www/node/Makefile head/www/node/distinfo head/www/node/files/patch-deps_v8_src_base_cpu.cc head/www/node/files/patch-node.gypi