Bug 228829 - [RFE] security/acme.sh: add C to the example newsyslog file
Summary: [RFE] security/acme.sh: add C to the example newsyslog file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dan Langille
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-08 14:58 UTC by Lapo Luchini
Modified: 2019-02-25 22:33 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (dvl)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lapo Luchini 2018-06-08 14:58:11 UTC
I followed instruction as per pkg-message, including symlinking the example newsyslog file to /usr/local/etc/newsyslog.conf.d
On first usage of "acme.sh" (from user "acme") I got a failure to create the log file, so I changed the "B" flag in the example newsyslog file to "BC", restarted, and now the file gets correctly created with the correct user and this the binary can add to it.
PS: I'm not sure the "B" flag is even needed, it seems a normal text log to me; maybe it was a typo for "C" all along?
Comment 1 Dan Langille freebsd_committer freebsd_triage 2018-06-18 13:29:29 UTC
The B was personal choice.  I prefer not to have the 'log file rotated' messages at the top and bottom of the log files when they are rotated.

Yes, the C can be added.

I now we think should install a sample newsyslog file directly to /usr/local/etc/newsyslog.conf.d, with the relevant bits commented out.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-02-25 22:32:10 UTC
A commit references this bug:

Author: dvl
Date: Mon Feb 25 22:31:40 UTC 2019
New revision: 493903
URL: https://svnweb.freebsd.org/changeset/ports/493903

Log:
  Upgrade to 2.8.0
  Add a C to the syslog.conf example and comment it out
  Make this pass testport by moving stuff from pkg-install into the Makefile

  PR:		228829,236041,228791
  Submitted by:	Lapo Luchini <lapo@lapo.it>,Frank Wall <fw@moov.de>,Mark Felder <feld@FreeBSD.org>

Changes:
  head/security/acme.sh/Makefile
  head/security/acme.sh/distinfo
  head/security/acme.sh/files/account.conf.sample
  head/security/acme.sh/files/acme.sh.conf
  head/security/acme.sh/files/pkg-install.in
  head/security/acme.sh/pkg-plist
Comment 3 Dan Langille freebsd_committer freebsd_triage 2019-02-25 22:32:37 UTC
Thank you.