Bug 228887 - databases/leofs: update 1.3.8 -> 1.4.1
Summary: databases/leofs: update 1.3.8 -> 1.4.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-11 12:15 UTC by Kurt Jaeger
Modified: 2018-06-11 18:25 UTC (History)
2 users (show)

See Also:
pi: maintainer-feedback+

Attachments
patch (11.08 KB, patch)
2018-06-11 12:15 UTC, Kurt Jaeger 		no flags Details | Diff
patch-v2 (11.87 KB, patch)
2018-06-11 14:12 UTC, Kurt Jaeger 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2018-06-11 12:15:51 UTC 
Created attachment 194162 [details]
patch

See attached diff. Needs buildtests in poudriere, run-tests.
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2018-06-11 12:56:21 UTC 
Buildtests in poudriere on 11.1a, 10.4i are fine.
Comment 2 Mikolaj Golub freebsd_committer freebsd_triage 2018-06-11 13:48:46 UTC 
Hi Kurt,

Cool! Thanks!

Looks good to me.

The only issue I saw when tried this:

gmake[1]: Entering directory '/home/mgolub/ports/databases/leofs/work/leofs-1.4.1'
for reltool_config in rel/leo_*/reltool.config.in; do \
	./make_reltool.sh no $reltool_config > $(echo $reltool_config | sed s/.in$//); \
done
/bin/sh: ./make_reltool.sh: not found
/bin/sh: ./make_reltool.sh: not found
/bin/sh: ./make_reltool.sh: not found
gmake[1]: *** [Makefile:55: reltool] Error 127
gmake[1]: Leaving directory '/home/mgolub/ports/databases/leofs/work/leofs-1.4.1'

Didn't you need to fix the shebang in make_reltool.sh to make it work?
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2018-06-11 14:12:20 UTC 
Created attachment 194169 [details]
patch-v2

Ups, yes, I forgot to add the patch to the diff. Attached now.

Did you run-test the update ?

If you approve, I'll commit this update.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2018-06-11 14:17:36 UTC 
Nah, you're a ports committer, you can commit that yourself 8-}
Comment 5 Mikolaj Golub freebsd_committer freebsd_triage 2018-06-11 17:35:12 UTC 
LGTM. Please go head with committing this. (I can commit myself if you have some problems with this).
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2018-06-11 18:24:37 UTC 
Committed, thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-06-11 18:25:23 UTC 
A commit references this bug:

Author: pi
Date: Mon Jun 11 18:24:24 UTC 2018
New revision: 472198
URL: https://svnweb.freebsd.org/changeset/ports/472198

Log:
  databases/leofs: update 1.3.8 -> 1.4.1

  PR:		228887
  Requested by:	Franco Ricci <franco.ricc@gmail.com>
  Approved by:	trociny (maintainer)
  Relnotes:	https://github.com/leo-project/leofs/releases

Changes:
  head/databases/leofs/Makefile
  head/databases/leofs/distinfo
  head/databases/leofs/files/patch-make_reltool.sh