Bug 228909 - x11-toolkits/scintilla & editors/scite: Update to 4.1.0
Summary: x11-toolkits/scintilla & editors/scite: Update to 4.1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-12 02:37 UTC by Naram Qashat
Modified: 2019-01-28 06:19 UTC (History)
1 user (show)

See Also:

Attachments
scintilla-4.0.5.patch (3.24 KB, patch)
2018-06-12 02:37 UTC, Naram Qashat 		cyberbotx: maintainer-approval+
Details | Diff
scite-4.0.5.patch (6.25 KB, patch)
2018-06-12 02:37 UTC, Naram Qashat 		cyberbotx: maintainer-approval+
Details | Diff
scintilla-4.1.0.patch (3.24 KB, patch)
2018-06-22 14:43 UTC, Naram Qashat 		cyberbotx: maintainer-approval+
Details | Diff
scite-4.1.0.patch (6.25 KB, patch)
2018-06-22 14:43 UTC, Naram Qashat 		cyberbotx: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2018-06-12 02:37:09 UTC 
Created attachment 194183 [details]
scintilla-4.0.5.patch

* Update both to 4.0.5
* Update both to use compiler:c++17-lang
* Update distinfo on both
* Update patches on both as followed:
  - x11-toolkits/scintilla: updated patch-makefile
  - editors/scite: removed patch-makefile and added patch-gtk-makefile and patch-src_EditorConfig.cxx (this was necessary due to WRKSRC being different from WRKDIR and the latter is outside of WRKSRC)
* Mark x11-toolkits/scintilla as broken for FreeBSD 10, this is due to their use of C++17 (unsure if editors/scite needs to be marked as broken for FreeBSD 10 as well due its dependency on scintilla)
  - See http://kirby.cyberbotx.com:8765/poudriere/data/10amd64-default/2018-06-11_19h42m26s/logs/errors/scintilla-4.0.5.log

Scintilla's full changelog can be found here:
https://www.scintilla.org/ScintillaHistory.html

SciTE does not have a full changelog but the brief of the changes can be found here:
https://www.scintilla.org/SciTE.html

Tested with poudriere for 11-i386 and 11-amd64. Was not tested for 10 at all due to the above note regarding C++17. Passes portlint (scite complains about using pkg-plist for 4 files, unsure if it should be changed at this point though).

Patch for scite will be in next edit.
Comment 1 Naram Qashat 2018-06-12 02:37:45 UTC 
Created attachment 194184 [details]
scite-4.0.5.patch
Comment 2 Naram Qashat 2018-06-22 14:43:06 UTC 
Created attachment 194503 [details]
scintilla-4.1.0.patch

Scintilla and SciTE 4.1.0 have come out in the last few days, so I am updating this to reflect that.

Changelog is in the same place as the original message. (I only realized after-the-fact that SciTE's changes are included in the Scintilla changelog.)

Tested with poudriere for 11-amd64 and 11-i386. Passes portlint.
Comment 3 Naram Qashat 2018-06-22 14:43:27 UTC 
Created attachment 194504 [details]
scite-4.1.0.patch
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-01-27 23:53:54 UTC 
A commit references this bug:

Author: swills
Date: Sun Jan 27 23:53:31 UTC 2019
New revision: 491444
URL: https://svnweb.freebsd.org/changeset/ports/491444

Log:
  x11-toolkits/scintilla: update to 4.1.0

  PR:		228909
  Submitted by:	Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)

Changes:
  head/x11-toolkits/scintilla/Makefile
  head/x11-toolkits/scintilla/distinfo
  head/x11-toolkits/scintilla/files/patch-makefile
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-01-27 23:57:59 UTC 
A commit references this bug:

Author: swills
Date: Sun Jan 27 23:57:43 UTC 2019
New revision: 491445
URL: https://svnweb.freebsd.org/changeset/ports/491445

Log:
  editors/scite: update to 4.1.0

  PR:		228909
  Submitted by:	Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)

Changes:
  head/editors/scite/Makefile
  head/editors/scite/distinfo
  head/editors/scite/files/patch-gtk_makefile
  head/editors/scite/files/patch-makefile
  head/editors/scite/files/patch-src_EditorConfig.cxx
Comment 6 Steve Wills freebsd_committer freebsd_triage 2019-01-28 00:00:24 UTC 
Committed, thanks for the patch, sorry it took so long.