Created attachment 194389 [details] svn diff Redis::Fast is 4x faster than Redis.pm in pipeline mode. refs: https://github.com/shogo82148/Redis-Fast * portlint ok * poudriere testport ok (11.1, amd64, svn-head) * make test ok
Created attachment 194390 [details] svn diff WWW added.
Testbuilds in poudriere fail early, see http://people.freebsd.org/~pi/logs/p5-Redis-Fast.txt Then: Upstream has 0.21, is there a special reason to prefer 0.18 ?
Created attachment 194415 [details] svn diff There is no special reason. Updated to 0.21. If redis binary is found, a heavy test runs. It takes about 3 minutes. If redis binary is not found, the test ends in a moment.
recheck done. poudriere testport ok (11.1, amd64, svn-head)
Can you put your poudriere build log up somewhere so that we can compare ?
Created attachment 194416 [details] poudriere testport log I'm sorry for bothering you.
Hmm, our setups differ: - ccache or not - /etc/make.conf settings or not - probably other things as well So, the port is not building in every case. We need to find a solution for that. Btw, when I add USES=gmake, it builds, but fails at stage with a different error. See http://people.freebsd.org/~pi/logs/databases__p5-Redis-Fast-cur-1529475243.txt
I think that the combination of USE_PERL5=modbuild and USES=perl5 gmake is not suitable. gmake will be detected in work/Redis-Fast-0.21/builder/MyBuilder.pm if installed. This is enough and no other mechanism is required. If you change Mk/Uses/perl5.mk as follows, testport passes with USES=perl5 gmake as well. --- /usr/ports-svn/head/Mk/Uses/perl5.mk 2018-06-20 15:58:02.370723000 +0900 +++ /usr/ports-svn/head/Mk/Uses/perl5.mk.mod 2018-06-20 16:36:24.046263000 +0900 @@ -266,12 +266,10 @@ @(cd ${BUILD_WRKSRC}; ${SETENV} ${MAKE_ENV} ${PERL5} ${PL_BUILD} ${ALL_TARGET} ${MAKE_ARGS}) . endif # !target(do-build) -. if !${USES:Mgmake} . if !target(do-install) do-install: @(cd ${BUILD_WRKSRC}; ${SETENV} ${MAKE_ENV} ${PERL5} ${PL_BUILD} ${INSTALL_TARGET} ${MAKE_ARGS}) . endif # !target(do-install) -. endif # ! USES=gmake . endif # modbuild PACKLIST_DIR?= ${PREFIX}/${SITE_ARCH_REL}/auto > http://people.freebsd.org/~pi/logs/databases__p5-Redis-Fast-cur-1529475243.txt I have already encountered this. So in the attachment 194415 [details] above BUILD_DEPENDS+=gmake:devel/gmake instead of USES=gmake. (To follow more deeply please try the following. make -d A stage 2>&1 | grep gmake | tail -1 ) I stopped using ccache and made make.conf empty and tried it, but testport passes. Does the problem continue with attachment 194415 [details]? Thank you for your cooperation.
A commit references this bug: Author: pi Date: Wed Jun 20 11:19:14 UTC 2018 New revision: 472865 URL: https://svnweb.freebsd.org/changeset/ports/472865 Log: New port: databases/p5-Redis-Fast Perl binding for Redis database. Redis::Fast is 4x faster than Redis.pm in pipeline mode. WWW: https://metacpan.org/release/Redis-Fast PR: 229141 Submitted by: Tomohiro Hosaka <bokutin@bokut.in> Changes: head/databases/Makefile head/databases/p5-Redis-Fast/ head/databases/p5-Redis-Fast/Makefile head/databases/p5-Redis-Fast/distinfo head/databases/p5-Redis-Fast/files/ head/databases/p5-Redis-Fast/files/patch-deps_hiredis_Makefile head/databases/p5-Redis-Fast/pkg-descr head/databases/p5-Redis-Fast/pkg-plist
Committed, thanks!
(In reply to Tomohiro Hosaka from comment #8) Thanks for the details explaination. TODO: New PR with the suggested perl5.mk change, requesting an exp-run if something breaks.
Can I help you with something?
The previous comment is a mistake. Please ignore.
CC'd perl for changes in perl5.mk.
Please open a real PR with a real patch that can be looked at. But looking at the thing that looks like a unusable patch, it is most probably going to be rejected.