Bug 229369 - lang/swift: Don't install sphinx unless building docs
Summary: lang/swift: Don't install sphinx unless building docs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-27 16:12 UTC by Adam Weinberger
Modified: 2018-06-27 22:22 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (swills)

Attachments
Conditionalize sphinx-build (563 bytes, patch)
2018-06-27 16:12 UTC, Adam Weinberger 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer freebsd_triage 2018-06-27 16:12:35 UTC 
Created attachment 194680 [details]
Conditionalize sphinx-build

Hey, Steve.

Right now, lang/swift depends on sphinx-build unconditionally, which brings in about 20 extra dependencies. However, it's not needed at all when DOCS is off.

The attached patch makes that dependency, and the attempt to build docs, dependent on the DOCS option.
Comment 1 Steve Wills freebsd_committer freebsd_triage 2018-06-27 22:10:43 UTC 
(In reply to Adam Weinberger from comment #0)
Approved, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-06-27 22:18:59 UTC 
A commit references this bug:

Author: adamw
Date: Wed Jun 27 22:18:32 UTC 2018
New revision: 473461
URL: https://svnweb.freebsd.org/changeset/ports/473461

Log:
  Put sphinx-build behind DOCS options, rather than bringing it in unconditionally

  PR:		229369
  Approved by:	maintainer (swills)

Changes:
  head/lang/swift/Makefile
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2018-06-27 22:22:52 UTC 
Done. Thanks Steve!