Bug 229853 - audio/audacity: Unbundle portaudio
Summary: audio/audacity: Unbundle portaudio
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-07-18 03:08 UTC by Tobias Kortkamp
Modified: 2018-07-19 03:20 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (xxjack12xx)

Attachments
audacity.diff (3.22 KB, patch)
2018-07-18 03:08 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (xxjack12xx)
 Details | Diff
portaudio with less patching (2.11 KB, patch)
2018-07-18 21:12 UTC, Jack 		xxjack12xx: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2018-07-18 03:08:17 UTC 
Created attachment 195226 [details]
audacity.diff

Hi,

I applied Audacity's portaudio.patch to audio/portaudio in ports r474829, so
now it should be possible for audio/audacity to depend on audio/portaudio
instead of the bundled version.  This makes it possible to use sndio with
Audacity.
Comment 1 Jack 2018-07-18 04:21:30 UTC 
I'll check.
Comment 2 Jack 2018-07-18 21:12:23 UTC 
Created attachment 195260 [details]
portaudio with less patching

Modified original patch to not remove anything from the distribution and no need to patch distro portaudio Makefile if portaudio=system is used.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-07-19 03:19:15 UTC 
A commit references this bug:

Author: tobik
Date: Thu Jul 19 03:18:53 UTC 2018
New revision: 474923
URL: https://svnweb.freebsd.org/changeset/ports/474923

Log:
  audio/audacity: Unbundle portaudio and use audio/portaudio instead

  PR:		229853
  Submitted by:	tobik
  Approved by:	xxjack12xx@gmail.com (maintainer)

Changes:
  head/audio/audacity/Makefile
  head/audio/audacity/files/patch-src_AudioIO.cpp
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2018-07-19 03:20:08 UTC 
Committed. Thanks!