Bug 229857 - x11/alacritty: update to newer snapshot (20180717)
Summary: x11/alacritty: update to newer snapshot (20180717)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks: 229684
  Show dependency treegraph
 
Reported: 2018-07-18 09:09 UTC by Sascha Holzleiter
Modified: 2018-08-14 15:29 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (zeising)


Attachments
alacritty update patch (46.50 KB, patch)
2018-07-18 09:09 UTC, Sascha Holzleiter
no flags Details | Diff
alacritty update patch rev2 (47.11 KB, patch)
2018-07-18 16:32 UTC, Sascha Holzleiter
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Holzleiter 2018-07-18 09:09:19 UTC
Created attachment 195235 [details]
alacritty update patch

This patch updates alacritty to a newer git snapshot.

The sole patch in files/ can be deleted. svn diff doesn't seem to act on deleted dirs...

Basically what i've done is using a newer tag and updating the dependencies according to Cargo.lock of the project. I've been using this for 2 days and it seems stable.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-07-18 10:28:00 UTC
(In reply to Sascha Holzleiter from comment #0)
Why is BUILD_DEPENDS=cmake:devel/cmake needed?  Please remove it.  It should
already be pulled in by virtue of having cmake in CARGO_CRATES.  Same with
freetype-sys and LIB_DEPENDS=libfreetype.so.
 
Probably a good time to install the new man page and shell completion
files too.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2018-07-18 10:46:32 UTC
(In reply to Sascha Holzleiter from comment #0)
> Basically what i've done is using a newer tag and updating the dependencies 
> according to Cargo.lock of the project. I've been using this for 2 days and it  > seems stable.

This seems to have been done manually.  Please use `make cargo-crates` to
generate CARGO_CRATES from Cargo.lock.  Some crates are no longer needed now.
Comment 3 Niclas Zeising freebsd_committer freebsd_triage 2018-07-18 11:07:06 UTC
Hi!
Thanks for the submission!
There's a bunch of comments on this already, which should probably be fixed.  I'll look, but might not have time until the weekend.
Comment 4 Sascha Holzleiter 2018-07-18 16:32:27 UTC
Yes, this was done manually... if i only had known we have something like `make cargo-crates`.

Ok, i regenerated using cargo-crates, added the man pages and completions.
I also got rid of all but one of the dependencies. Without fontconfig i get a compile error.

The new patch should have it all.
Comment 5 Sascha Holzleiter 2018-07-18 16:32:57 UTC
Created attachment 195252 [details]
alacritty update patch rev2
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-13 14:48:36 UTC
LGTM. Any reason to delay yet?
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-08-14 15:28:34 UTC
A commit references this bug:

Author: tobik
Date: Tue Aug 14 15:27:51 UTC 2018
New revision: 477165
URL: https://svnweb.freebsd.org/changeset/ports/477165

Log:
  x11/alacritty: Update to newer snapshot

  PR:		229857
  Submitted by:	Sascha Holzleiter <sascha@root-login.org>
  Approved by:	maintainer timeout (~4 weeks)

Changes:
  head/x11/alacritty/Makefile
  head/x11/alacritty/distinfo
  head/x11/alacritty/files/