Bug 230151 - security/py-asyncssh: Update to 1.14.0 (Fixes security vulnerability: CVE-2018-7749)
Summary: security/py-asyncssh: Update to 1.14.0 (Fixes security vulnerability: CVE-201...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Some People
Assignee: Steve Wills
URL: https://github.com/ronf/asyncssh/blob...
Keywords: needs-qa, security
Depends on:
Blocks:
 
Reported: 2018-07-29 15:37 UTC by Nathan
Modified: 2018-12-09 01:53 UTC (History)
4 users (show)

See Also:
koobs: merge-quarterly?


Attachments
Update (944 bytes, patch)
2018-07-29 15:37 UTC, Nathan
no flags Details | Diff
Python Test (107.66 KB, text/plain)
2018-08-01 21:57 UTC, Nathan
no flags Details
Poudriere Log for Py3 (40.12 KB, text/plain)
2018-08-01 23:41 UTC, Nathan
no flags Details
Poudriere Log for py2.7 (53.41 KB, text/plain)
2018-08-01 23:43 UTC, Nathan
no flags Details
vuxml (1.35 KB, patch)
2018-09-10 01:40 UTC, Nathan
ndowens04: maintainer-approval+
Details | Diff
Update; Fix CVE-2018-7749 (1.37 KB, patch)
2018-09-10 04:27 UTC, Nathan
ndowens04: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan 2018-07-29 15:37:09 UTC
Created attachment 195595 [details]
Update

In 1.12.1 and important CVE fix was added CVE-2018-7749, where a modified SSH client could request that an AsyncSSH server perform operations before authentication had completed

https://github.com/ronf/asyncssh/blob/master/docs/changes.rst : Release Notes

For this version 1.13.3:

Added support for setting the Unicode error handling strategy in conjunction with setting an encoding when creating new SSH sessions, streams, and processes. This strategy can also be set when specifying a session encoding in create_server(), and when providing an encoding in the get_comment() and set_comment() functions on private/public keys and certificates.
    Changed handling of Unicode in channels to use incrmeental codec, similar to what was previously done in process redirection.
    Added Python 3.7 to the list of classifiers in setup.py, now that it has been released.
    Updated Travis CI configuration to add Python 3.7 builds, and moved Linux builds on never versions of Python up to xenial.
    Added missing coroutine decorator in test_channel.
Comment 1 Jochen Neumeister freebsd_committer freebsd_triage 2018-07-30 17:52:48 UTC
Bugzilla was unable to make any match at all for one or more of the names and/or email addresses you entered on the previous page.

Please go back and try other names or email addresses.
maintainer-feedback requestee: 	
bartosz@ixsystems.com did not match anything 

unknow Maintainer

@Koobs can this committed without Maintainer feedback?
Comment 2 Nathan 2018-07-30 20:00:03 UTC
Yeah I tried doing that as well. I would say pkg is abandoned
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2018-08-01 09:39:53 UTC
If the title on original bug entry had matched the portname, Bugzilla would have emailed the maintainer, who doesn't currently have an account on the system, but should. 

Since that mechanism is only triggered on new bug creation (not subsequent title changes), I would manually email the maintainer requesting that they create an account here and request approval on that basis

Two week timeout period would begin after sending that email.

Having said that, since this is a security related issue, it can also be approved by ports-secteam (now CC'd)

In the meantime, the security/vuxml entry can be landed, so go ahead on that
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2018-08-01 09:44:00 UTC
Please also provide QA confirmation (portlint, poudriere, py2/3), especially since this will be merged to the quarterly branch.

Ideally this includes running the packages test suite (which exist). Judging by the setup.py file, one should be able to just add:

do-test:
   @cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test

Some TEST_DEPENDS may be necessary if the test suite fails (not skips) tests that want non-compulsory dependencies.
Comment 5 Nathan 2018-08-01 14:23:31 UTC
Emailed maintainer. Added test and so far there is four fails
Comment 6 Nathan 2018-08-01 21:57:07 UTC
Created attachment 195731 [details]
Python Test

As far as I can tell, the error is saying it can't find sspi_stub module but I do see it in tests/ folder
Comment 7 Nathan 2018-08-01 23:39:41 UTC
(In reply to Kubilay Kocak from comment #4)
> Please also provide QA confirmation (portlint, poudriere, py2/3), especially
> since this will be merged to the quarterly branch.
> 
> Ideally this includes running the packages test suite (which exist). Judging
> by the setup.py file, one should be able to just add:
> 
> do-test:
>    @cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test
> 
> Some TEST_DEPENDS may be necessary if the test suite fails (not skips) tests
> that want non-compulsory dependencies.

⇒  portlint -AC 
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
Comment 8 Nathan 2018-08-01 23:41:56 UTC
Created attachment 195735 [details]
Poudriere Log for Py3
Comment 9 Nathan 2018-08-01 23:43:24 UTC
Created attachment 195736 [details]
Poudriere Log for py2.7
Comment 10 Nathan 2018-08-01 23:45:19 UTC
(In reply to Nathan from comment #9)
> Created attachment 195736 [details]
> Poudriere Log for py2.7

I do believe that the update is only for python3+
Comment 11 Nathan 2018-09-10 01:40:54 UTC
Created attachment 196995 [details]
vuxml

vuxml entry
Comment 12 Nathan 2018-09-10 04:27:51 UTC
Created attachment 196997 [details]
Update; Fix CVE-2018-7749

 security/py-asyncssh:
 
 * Update to 1.14.0
   -- Fixes CVE-2018-7749
 
 Changelog: https://github.com/ronf/asyncssh/blob/v1.14.0/docs/changes.rst

portlint -AC: Fixed a space to a tab; looks fine now(Think that may be why maintainer wasn't informed?)

poudriere(amd64/i386): 11.2 12-cur: Built fine

4/900+ tests failed, reported:
https://github.com/ronf/asyncssh/issues/165
Comment 13 Nathan 2018-09-13 02:13:14 UTC
Builds on (armv6/arm64/mips/mips64) 12
Comment 14 Jochen Neumeister freebsd_committer freebsd_triage 2018-11-11 20:01:59 UTC
any news here?
Comment 15 Kubilay Kocak freebsd_committer freebsd_triage 2018-11-13 02:05:51 UTC
Assignee timeout (2+ months), open to take
Comment 16 commit-hook freebsd_committer freebsd_triage 2018-12-09 01:48:11 UTC
A commit references this bug:

Author: swills
Date: Sun Dec  9 01:47:39 UTC 2018
New revision: 487009
URL: https://svnweb.freebsd.org/changeset/ports/487009

Log:
  security/py-asyncssh: Update to 1.14.0

  While here, add test target

  PR:		230151
  Submitted by:	Nathan <ndowens@yahoo.com>
  Approved by:	maintainer timeout (bartosz@ixsystems.com, >2 months)
  MFH:		2018Q4
  Security:	0e8f496a-b498-11e8-bdcf-74d435e60b7c

Changes:
  head/security/py-asyncssh/Makefile
  head/security/py-asyncssh/distinfo
Comment 17 commit-hook freebsd_committer freebsd_triage 2018-12-09 01:50:15 UTC
A commit references this bug:

Author: swills
Date: Sun Dec  9 01:49:15 UTC 2018
New revision: 487010
URL: https://svnweb.freebsd.org/changeset/ports/487010

Log:
  MFH: r487009

  security/py-asyncssh: Update to 1.14.0

  While here, add test target

  PR:		230151
  Submitted by:	Nathan <ndowens@yahoo.com>
  Approved by:	maintainer timeout (bartosz@ixsystems.com, >2 months)
  Security:	0e8f496a-b498-11e8-bdcf-74d435e60b7c

  Approved by:	ports-secteam (implicit)

Changes:
_U  branches/2018Q4/
  branches/2018Q4/security/py-asyncssh/Makefile
  branches/2018Q4/security/py-asyncssh/distinfo
Comment 18 Steve Wills freebsd_committer freebsd_triage 2018-12-09 01:53:21 UTC
Committed, thanks!